test__hybrid_formulae.py nose discovery #4450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjbenfold
force-pushed
the
wjbenfold-test-hybrid-formulae-discovery
branch
from
f06b527
to
76fae75
Compare
rcomer
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Thanks @wjbenfold!
Confirmed that the CI is now finding 5977 tests, whereas the last commit to main only found 5970.
I have convinced myself that the new tests are equivalent to the generated ones, and that each of the new tests is checking a different hybrid_type.
LGTM
|
Oh, it should probably have a whatsnew though! |
Merged
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 7, 2021
* main: [pre-commit.ci] pre-commit autoupdate (SciTools#4452) Whatsnew (SciTools#4451) Explicitly define tests so nose can find them (SciTools#4450) Updated environment lockfiles (SciTools#4449) Update CI environment lockfiles (SciTools#4424) Disable GHA workflows on non-SciTools branches (SciTools#4444) Add new contributor to whatsnew (SciTools#4443) Use dask-core instead of dask in ci (SciTools#4434) Mesh recombine (SciTools#4437) Mesh full comparison (SciTools#4439) Only try to work out the differences between points for multiple (SciTools#4367) [pre-commit.ci] pre-commit autoupdate (SciTools#4430) Fix license PyPI classifier (SciTools#4435) Whatsnew for PR SciTools#4367 (SciTools#4440)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 14, 2021
* upstream/main: (78 commits) Updated environment lockfiles (SciTools#4458) remove asv package dependency (SciTools#4456) cube.aggregated_by output bounds (SciTools#4315) [pre-commit.ci] pre-commit autoupdate (SciTools#4452) Whatsnew (SciTools#4451) Explicitly define tests so nose can find them (SciTools#4450) Updated environment lockfiles (SciTools#4449) Update CI environment lockfiles (SciTools#4424) Disable GHA workflows on non-SciTools branches (SciTools#4444) Add new contributor to whatsnew (SciTools#4443) Use dask-core instead of dask in ci (SciTools#4434) Mesh recombine (SciTools#4437) Mesh full comparison (SciTools#4439) Only try to work out the differences between points for multiple (SciTools#4367) [pre-commit.ci] pre-commit autoupdate (SciTools#4430) Fix license PyPI classifier (SciTools#4435) Whatsnew for PR SciTools#4367 (SciTools#4440) Suggest type hinting (SciTools#4390) area weight regrid test fixes (SciTools#4432) Update latest.rst (SciTools#4425) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Fixes #4431 which highlights that the method used to construct some tests in
iris/tests/unit/fileformats/nc_load_rules/actions/test__hybrid_formulae.pywasn't allowing them to be picked up bynose. I've expanded the short method that was being used to make the tests into a repetitive setup that should be picked up bynose, hopefully exactly replicating the previous tests.Consult Iris pull request check list