Use dask-core instead of dask in ci #4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SciTools-assistant
added
the
Blocked: CLA needed
Merged
5 tasks
|
Signed CLA now |
|
Thanks for signing the CLA @aaronspring ! I'm not sure why the cla checker hasn't updated but sometimes this can be fixed by closing and reopening the PR. I'm going to do that now to see if that helps! |
SciTools-assistant
removed
the
Blocked: CLA needed
lbdreyer
requested changes
Nov 26, 2021
There was a problem hiding this comment.
Thanks for this @aaronspring ! It would be good to trim the dependencies that get installed.
Could I also ask you to add an entry to the whats new summarising this change? There is some guidance in the docs on how to do this (see https://scitools-iris.readthedocs.io/en/stable/developers_guide/documenting/whats_new_contributions.html)
lbdreyer
approved these changes
Nov 30, 2021
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 7, 2021
* main: [pre-commit.ci] pre-commit autoupdate (SciTools#4452) Whatsnew (SciTools#4451) Explicitly define tests so nose can find them (SciTools#4450) Updated environment lockfiles (SciTools#4449) Update CI environment lockfiles (SciTools#4424) Disable GHA workflows on non-SciTools branches (SciTools#4444) Add new contributor to whatsnew (SciTools#4443) Use dask-core instead of dask in ci (SciTools#4434) Mesh recombine (SciTools#4437) Mesh full comparison (SciTools#4439) Only try to work out the differences between points for multiple (SciTools#4367) [pre-commit.ci] pre-commit autoupdate (SciTools#4430) Fix license PyPI classifier (SciTools#4435) Whatsnew for PR SciTools#4367 (SciTools#4440)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 14, 2021
* upstream/main: (78 commits) Updated environment lockfiles (SciTools#4458) remove asv package dependency (SciTools#4456) cube.aggregated_by output bounds (SciTools#4315) [pre-commit.ci] pre-commit autoupdate (SciTools#4452) Whatsnew (SciTools#4451) Explicitly define tests so nose can find them (SciTools#4450) Updated environment lockfiles (SciTools#4449) Update CI environment lockfiles (SciTools#4424) Disable GHA workflows on non-SciTools branches (SciTools#4444) Add new contributor to whatsnew (SciTools#4443) Use dask-core instead of dask in ci (SciTools#4434) Mesh recombine (SciTools#4437) Mesh full comparison (SciTools#4439) Only try to work out the differences between points for multiple (SciTools#4367) [pre-commit.ci] pre-commit autoupdate (SciTools#4430) Fix license PyPI classifier (SciTools#4435) Whatsnew for PR SciTools#4367 (SciTools#4440) Suggest type hinting (SciTools#4390) area weight regrid test fixes (SciTools#4432) Update latest.rst (SciTools#4425) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Tried to reduce dependencies from installing dask via conda which installs like pip install dask[complete]. dask-core is like pip install dask. xgcm/xhistogram#71 (comment)
Why? dask[complete] includes bokeh etc which are not needed here and likely speed up CI setup/install times
consider also for feedstock conda-forge/iris-feedstock#77
Consult Iris pull request check list