Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake8 dependency #4371

Merged
merged 2 commits into from
Oct 13, 2021
Merged

flake8 dependency #4371

merged 2 commits into from
Oct 13, 2021

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Oct 13, 2021

🚀 Pull Request

Description

flake8 was deliberately dropped from the requirements at #4181, but then reintroduced within the mergeback at #4276. I suspect this was not intended.


Consult Iris pull request check list

@rcomer
Copy link
Member Author

rcomer commented Oct 13, 2021

Guess I should update the lockfiles?

@bjlittle
Copy link
Member

@rcomer How is the heck did you spot that?

A pretty studding catch! Nice one 👍

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rcomer Brilliant, thanks 😄

@bjlittle bjlittle merged commit 79bd65d into SciTools:main Oct 13, 2021
@rcomer
Copy link
Member Author

rcomer commented Oct 13, 2021

@rcomer How is the heck did you spot that?

I was wondering what pillow is for, so went to check which category of dependency it falls under... 😆

@rcomer rcomer deleted the yml-flake8 branch October 15, 2021 13:49
tkknight added a commit to tkknight/iris that referenced this pull request Nov 3, 2021
* main: (44 commits)
  [pre-commit.ci] pre-commit autoupdate (SciTools#4395)
  min pin for numpy (nep29) (SciTools#4386)
  Updated environment lockfiles (SciTools#4393)
  Extend stock.mesh api (SciTools#4389)
  Updated environment lockfiles (SciTools#4388)
  Integrate ASV with Nox (SciTools#4378)
  NetCDF save - stream ALL lazy arrays. (SciTools#4375)
  adopt flake8 maccabe complexity metric (SciTools#4380)
  Accept inverse_flattening = 0 for spherical ellipsoid (closes SciTools#4146) (SciTools#4368)
  Updated environment lockfiles (SciTools#4379)
  Prevent warning in `test_Saver` (SciTools#4376)
  drop pyugrid in site.cfg (SciTools#4373)
  `flake8` dependency (SciTools#4371)
  update latest whosnew (SciTools#4372)
  Allow `check_graphic` to be more flexible (SciTools#4370)
  [pre-commit.ci] pre-commit autoupdate (SciTools#4365)
  Updated environment lockfiles (SciTools#4364)
  Update latest.rst (SciTools#4362)
  More clarity on setting `iris-test-data` location. (SciTools#4359)
  update whatsnew (SciTools#4361)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants