Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More clarity on setting iris-test-data location. #4359

Merged
merged 3 commits into from
Oct 8, 2021

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

An addition to the documentation for regular developers who don't want to repeatedly use OVERRIDE_TEST_DATA_REPOSITORY. Thanks @bsherratt for helping me spot this missing info.


Consult Iris pull request check list

@trexfeathers trexfeathers changed the title More clarity on setting iris-test-data location. More clarity on setting iris-test-data location. Oct 7, 2021
@bjlittle bjlittle self-requested a review October 7, 2021 20:41
@bjlittle bjlittle self-assigned this Oct 7, 2021
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trexfeathers Looks good

Fancy making a whatsnew entry to highlight this change to the community 👍

@trexfeathers
Copy link
Contributor Author

Fancy making a whatsnew entry to highlight this change to the community 👍

Dammit I forget EVERY time!

@bjlittle bjlittle merged commit 8125c0d into SciTools:main Oct 8, 2021
tkknight added a commit to tkknight/iris that referenced this pull request Nov 3, 2021
* main: (44 commits)
  [pre-commit.ci] pre-commit autoupdate (SciTools#4395)
  min pin for numpy (nep29) (SciTools#4386)
  Updated environment lockfiles (SciTools#4393)
  Extend stock.mesh api (SciTools#4389)
  Updated environment lockfiles (SciTools#4388)
  Integrate ASV with Nox (SciTools#4378)
  NetCDF save - stream ALL lazy arrays. (SciTools#4375)
  adopt flake8 maccabe complexity metric (SciTools#4380)
  Accept inverse_flattening = 0 for spherical ellipsoid (closes SciTools#4146) (SciTools#4368)
  Updated environment lockfiles (SciTools#4379)
  Prevent warning in `test_Saver` (SciTools#4376)
  drop pyugrid in site.cfg (SciTools#4373)
  `flake8` dependency (SciTools#4371)
  update latest whosnew (SciTools#4372)
  Allow `check_graphic` to be more flexible (SciTools#4370)
  [pre-commit.ci] pre-commit autoupdate (SciTools#4365)
  Updated environment lockfiles (SciTools#4364)
  Update latest.rst (SciTools#4362)
  More clarity on setting `iris-test-data` location. (SciTools#4359)
  update whatsnew (SciTools#4361)
  ...
@trexfeathers trexfeathers deleted the changing_test_data_loc branch March 31, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants