Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkcheck ignore for iris pull and issue url #3873

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

tkknight
Copy link
Contributor

🚀 Pull Request

Description

Added 2 urls to be ignored when running the linkcheck to avoid spamming github when running a linkcheck.

Since we have started to use the pull and issue directives:

:issue:`9999`
:pull:`9999`

... in the what's new that is later substituted for a full url, when running the linkcheck from travis the host (github) may refuse the connection as it is essentially being hit frequently from many different travis jobs. This will show as a warning/error and fail the linkcheck travis task.

The ignore urls only covers Iris pull and issue, it will still check links to blobs (source code).


Consult Iris pull request check list

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkknight Nice one. We've had such issues before, do this change is most welcome 👍

@bjlittle bjlittle merged commit 37bf320 into SciTools:master Sep 21, 2020
@tkknight
Copy link
Contributor Author

thanks @bjlittle

tkknight added a commit to tkknight/iris that referenced this pull request Sep 22, 2020
* master:
  Use napolean extension in docs to handle numpy docstrings too (SciTools#3871)
  Added whats new for pr3873 (SciTools#3874)
  linkcheck ignore for iris pull and issue url (SciTools#3873)
  Remove all local table of contents (SciTools#3872)
  Added whats new entry for pr3852 (SciTools#3854)
@tkknight tkknight deleted the docs_linkcheck_ignore_iris branch September 22, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants