Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added whats new entry for pr3852 #3854

Merged
merged 3 commits into from
Sep 20, 2020

Conversation

tkknight
Copy link
Contributor

🚀 Pull Request

Description

Added whats new entry for #3852 Developer Guide Overhaul.

PR will be kept in DRAFT until #3852 is merged to master.


Consult Iris pull request check list

@tkknight tkknight mentioned this pull request Sep 15, 2020
1 task
@tkknight tkknight added this to the v3.0.0 milestone Sep 15, 2020
:ref:`developers_guide` including information on getting involved in
becoming a contributor and general structure of the guide. This resolves
:issue:`2170`, :issue:`2331`, :issue:`3453`. (:pull:`3852`)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking such an important change should be listed somewhere more prominent than this. Or are we planning some other way to flag that "it's now easier to get involved"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem that when cutting the release, some of the best features ought to be picked out in the same way as has been done previously (e.g. v2.3). It's tricky since that will need detailed knowledge of all the highlighted features!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can bank this as is.

Once the whatsnew is complete, if we want to showcase specific entries, then we can do that.

@bjlittle bjlittle marked this pull request as ready for review September 20, 2020 02:23
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkknight You'll need to resolve your conflicts first, otherwise LGTM 👍

* master:
  Whatsnew for effects on aux factories of units defaulting to 'unknown'. (SciTools#3870)
  Whatsnew entry for SciTools#3867. (SciTools#3868)
  Developer guide overhaul (SciTools#3852)
  Update CF standard name table to v75 (SciTools#3867)
  Link to new classes and methods in the Ancillary variables whatsnew. (SciTools#3865)
  update black version (SciTools#3866)
  Fix whatsnew api links. (SciTools#3856)
  Add additional pre-commit hooks (SciTools#3862)
  update pre-commit flake8 version (SciTools#3863)
  whatsnew - update announcement (SciTools#3861)
  whatsnew - remove contents directive (SciTools#3859)
  whatsnew - links and versions (SciTools#3853)
  Replace deprecated IndexFormatter (SciTools#3857)
  whatsnew for SciTools#3681 (SciTools#3858)
  Whatsnew entry for SciTools#3846. (SciTools#3855)
  Image tests: set agg backend after rcdefaults (SciTools#3846)
  whatnew - announcements (SciTools#3850)
@bjlittle
Copy link
Member

@tkknight Awesome, thanks 👍

@bjlittle bjlittle merged commit 0cd666e into SciTools:master Sep 20, 2020
tkknight added a commit to tkknight/iris that referenced this pull request Sep 22, 2020
* master:
  Use napolean extension in docs to handle numpy docstrings too (SciTools#3871)
  Added whats new for pr3873 (SciTools#3874)
  linkcheck ignore for iris pull and issue url (SciTools#3873)
  Remove all local table of contents (SciTools#3872)
  Added whats new entry for pr3852 (SciTools#3854)
@tkknight tkknight deleted the whats_new_for_pr3852 branch September 22, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants