-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit filelock use #2221
limit filelock use #2221
Conversation
with open(repo_fname, 'wb') as fo: | ||
json.dump(repo, codecs.getwriter('utf-8')(fo), indent=4, | ||
sort_keys=True) | ||
lock = filelock.FileLock(repo_fname) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an improvement over the initial proposal.
Thanks @marqh :) |
@marqh @lbdreyer @dkillick You've introduced a bug here ... The lock file imagerepo.lock is a separate file from the file imagerepo.json that the lock protects access to in the lock critical region. The code change that @lbdreyer merged uses the Line 737 should be replaced with the following: lock = filelock.FileLock(os.path.join(_RESULT_PATH, 'imagerepo.lock')) And line 811 now requires to be deleted ... infact the Someone needs to fix this now before |
@lbdreyer There are no tests to test the testing framework. |
This has always struck me as an abrupt irony. |
remove the behaviour, introduced in #2192, where installations without write permissions to the iris source directories are unable to run tests, due to
@bjlittle does this maintain your desired behaviour for developers whilst removing the installation and testing block?