Port test_grib_load_translations from iris #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
pp-mo
changed the title
I definitely agree with this! |
lbdreyer
reviewed
Feb 20, 2020
| } | ||
| ) | ||
| # Add edition-dependent settings. | ||
| self["edition"] = edition |
There was a problem hiding this comment.
Arguably you could edit this... but I don't think we need to worry about that right now
There was a problem hiding this comment.
The way this is written, it still suggests that you can control what you get depending on what edition you supply to _init_minimal_message ,when that's not quite true anymore. But you do assert the edition is 1 later on.
|
Overall I'm happy with this. I'll merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests ported from
iris.tests.test_grib_load_translations.Renamed and slightly simplified, as this (now) only tests the old GRIB-1 mechanisms.
A case could be made for combining this with the existing "sister" testcode
iris_grib.tests.unit.grib1_load_rules.test_grib1_convert, and unifying the approaches.But for GRIB1 I think this is strictly not worth it.
Maybe when we port GRIB1 to the new "strict" loader code ?