Fix GRIB1 support

[pp-mo]

The GRIB1 load translation code (here) is still using GribWrappers, which is the only thing preventing us throwing all the old loader code away, including the GribWrapper class.

Technical Debt summary :

• fix: rewrite grib1 loading using iris_grib.message.GribMessage instead
• legacy cost: clarity of main code structure; dread to maintain this (though little need has arisen)

---

[
In fact this is still the bulk of code in iris_grib.__init__.py, though no longer publicly exported.

• globals CENTRE_TITLES, TIME_RANGE_INDICATORS, PROCESSING_TYPES, TIME_CODES_EDITION1 and unknown_string
• classes GribDataProxy and GribWrapper
• functions _longitude_is_cyclic and _message_values
  ]

There is still a slippery kludge that means when you load a GRIB1 message the 'field' argument in a callback becomes a GribWrapper instead of a GribMessage (here).

So, this is now the only thing that GribWrapper is still used for, and the only remaining occasion that a user might possibly be concerned about what a GribWrapper looks like.

We haven't addressed this yet because GRIB1 usage is very low.

We should rewrite the Grib1 loader to use the modern message object + throw away all the old GribWrapper-based processing.

Tasks

Beta Give feedback

1. Write GRIB1 loading tests to modern standards #488
   Dragon Sub-Task 🦎 +1
2. Introduce an alternative GRIB1 loading using iris_grib.message.GribMessage instead #489
   Dragon Sub-Task 🦎 +1
3. Introduce switchable **opt-out** new-style GRIB1 loading #490
   Dragon Sub-Task 🦎 +1

[pp-mo]

Strategy ideas ...

Scoping

• We have a few grib1 files in the iris-test-data :

$ cd ...git/iris-test-data/test_data/GRIB
$ find . -iname "*.grib1"
./lambert/lambert.grib1
./rotated_uk/uk_wrongparam.grib1
./reduced/reduced_ll_missing.grib1
./reduced/reduced_ll.grib1
./shape_of_earth/global.grib1
./time_processed/time_bound.grib1
./gaussian/regular_gg.grib1

( N.B. all those contain only a single message )

• We can inspect, from existing code, what types of data the existing grib load rules can support

  • use coverage analysis to see how our tests / testfiles cover the code as it is

• we have some local test-case data + users to draw on ?

Strategy

• Get some tests that ensure what kinds of GRIB1 data we can read, and the results.
• write loading code using GribMessage for grib1, and compare against tests