-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend regridder saving/loading to all regridders #357
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
==========================================
+ Coverage 98.85% 98.92% +0.07%
==========================================
Files 37 37
Lines 3929 4196 +267
==========================================
+ Hits 3884 4151 +267
Misses 45 45 ☔ View full report in Codecov by Sentry. |
* main: Move benchmark code from nox to bm_runner (SciTools#361) Bump scitools/workflows from 2024.01.0 to 2024.04.3 (SciTools#356) Bump peter-evans/create-pull-request from 5.0.2 to 6.0.5 (SciTools#355) [pre-commit.ci] pre-commit autoupdate (SciTools#336) Updated environment lockfiles (SciTools#344)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really competent to comment on all the mechanics here.
But I have raised some 'style' points, including docstrings that seem to need changing.
Also, I think it probably needs a changelog entry ?
* main: Ensure dtype is preserved after regridding (SciTools#239)
OK I think this is all good now |
* main: Bump scitools/workflows from 2024.06.0 to 2024.06.5 (SciTools#377) Fix typo (SciTools#371) Bump scitools/workflows from 2024.04.3 to 2024.06.0 (SciTools#365) Update to v0.11.dev0. (SciTools#363) Update to v0.10.0 (SciTools#362) Extend regridder saving/loading to all regridders (SciTools#357) Ensure dtype is preserved after regridding (SciTools#239) Move benchmark code from nox to bm_runner (SciTools#361) # Conflicts: # esmf_regrid/schemes.py
Closes #318