Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare DAESolution for interpolation #622

Conversation

oscardssmith
Copy link
Contributor

@oscardssmith oscardssmith commented Feb 12, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.
This adds the k field to DAESolution which will allow for a future PR to OrdinaryDiffEq to make DAEs save their k's which is necessary to interpolate their solutions.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7611e76) 38.81% compared to head (a2627da) 38.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #622   +/-   ##
=======================================
  Coverage   38.81%   38.81%           
=======================================
  Files          55       55           
  Lines        4261     4261           
=======================================
  Hits         1654     1654           
  Misses       2607     2607           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oscardssmith oscardssmith force-pushed the os/prepare-DAESolution-for-interpolation branch from 51b0227 to e452f02 Compare February 12, 2024 21:42
@oscardssmith oscardssmith force-pushed the os/prepare-DAESolution-for-interpolation branch from e452f02 to 2cbff6c Compare February 12, 2024 21:49
@ChrisRackauckas ChrisRackauckas merged commit 0475fc3 into SciML:master Feb 13, 2024
29 of 42 checks passed
@oscardssmith oscardssmith deleted the os/prepare-DAESolution-for-interpolation branch February 13, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants