Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save du and k for DAEs when dense==true #2137

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

save du and k for DAEs when dense==true #2137

wants to merge 3 commits into from

Conversation

oscardssmith
Copy link
Contributor

@oscardssmith oscardssmith commented Feb 12, 2024 •
edited
Loading

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.
depends on SciML/SciMLBase.jl#622 to add the k field to DAESolution.

@oscardssmith oscardssmith force-pushed the save-du-and-k-for-DAEs branch from b5e2a0d to f494526 Compare February 12, 2024 21:49
@oscardssmith oscardssmith force-pushed the save-du-and-k-for-DAEs branch from b641412 to 8a2da2a Compare February 16, 2024 21:04
@ChrisRackauckas
Copy link
Member

Missing tests

@ChrisRackauckas
Copy link
Member

Bump for tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscardssmith @ChrisRackauckas