Allow cache module to be given in RGF constructor #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes the full constructor (without the need for specifying module tags), as we seem to need this for utility functions which want to cache the RGF in a user-specified module.
c42f
force-pushed
the
cjf/cache-module-in-constructor
branch
from
4249f30 to
eec806a
Compare
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 89.36% 93.33% +3.97%
==========================================
Files 1 1
Lines 47 45 -2
==========================================
Hits 42 42
+ Misses 5 3 -2
Continue to review full report at Codecov.
|
This was referenced Feb 6, 2021
|
Should this get mentioned in the README? I think it should, and it should be the "final" piece of this library. Thanks @c42f for taking the difficult parts on! |
#25 could be nice I guess. But really it would be great if the compiler just supported callable methods more directly... this library is always going to be a hack :-) |
|
A hack, but a useful one for at least the next year or two! |
|
Right! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the full constructor (without the need for specifying
module tags), as we seem to need this for utility functions which want
to cache the RGF in a user-specified module.
Looks like this is needed to make SciML/ModelingToolkit.jl#769 less hacky.