Work around to specify cache module when building RuntimeGeneratedFunctions #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2021
|
It would be good to get @c42f's opinion here. |
|
This seems valid to me (getting the caching right is tricky). We just need some support in RuntimeGeneratedFunctions to make it officially supported. See SciML/RuntimeGeneratedFunctions.jl#26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RuntimeGeneratedFunctions (RGF) macro
@RuntimeGeneratedFunctionallows the caller to specify the "context" module, but sets the "cache" module (i.e. which RGF cache will contain this function) to@__MODULE__, which ends up being ModelingToolkit.However, if a user is indirectly calling ModelingToolkit's
build_functionat precompile time, ModelingToolkit's cache eventually disappears, and the resulting RGF cache lookup does not work.Therefore, the user needs to set up an RGF cache in their own module, and ensure
build_functionis called withexpression=falseandexpression_module=UserModule. The work-around in this PR then sets both the RGF's "cache" and "context" modules to be theUserModule.