Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not enter minimize mode when closing views quickly in maximize mode (#24) #69

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

mofogasy
Copy link
Contributor

@mofogasy mofogasy commented Nov 30, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit follows our guidelines
  • Tests for the changes have been added (required for routing or view grid related issues)
  • Public API has been documented

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Issue

Issue Number: #24

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link
Collaborator

@danielwiehl danielwiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to SCION Workbench, LGTM!

@danielwiehl danielwiehl merged commit f914c54 into SchweizerischeBundesbahnen:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants