Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View tab receiving dblclick event #24

Closed
mofogasy opened this issue Sep 26, 2018 · 2 comments
Closed

View tab receiving dblclick event #24

mofogasy opened this issue Sep 26, 2018 · 2 comments
Assignees

Comments

@mofogasy
Copy link
Contributor

Current behavior

When closing two (or more) view tabs in quick succession, a dblclick event is fired and delivered to the second view tab, which toggles the maximize mode of the main content.

Expected behavior

When clicking in quick succession to close view tabs, the tabs should be closed without toggling maximize mode (or if tabs have different widths, then the next tab should be activated).

Minimal reproduction of the problem with instructions

Plunkr that demonstrates how an element receives a dblclick event, even though only clicked once:
https://plnkr.co/edit/vrUVABv25rwhtnXxrw8F?p=preview

Reproduce in SCION - Angular Workbench Demo

  1. Go to https://blog.sbb.technology/scion-workbench-demo/#/(view.6:person/69//view.5:person/75//view.4:person/9//view.3:person/54//activity:person-list)?viewgrid=WyJ2aWV3cGFydC4xIiwidmlldy4zIiwidmlldy4zIiwidmlldy40Iiwidmlldy41Iiwidmlldy42Il0%3D
  2. Double-click on the 'x' of the first tab
  3. Tab is closed, but at the same time, the content is maximized

Environment

  • SCION Workbench version: 0.0.0-beta.10
@danielwiehl
Copy link
Collaborator

Thank you for submitting this pull request and welcome to our community. We are excited to review your changes, and you should get some feedback from us soon.

@danielwiehl
Copy link
Collaborator

Merged into master. Thank you @mofogasy for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants