Issues 159 and 160 #161
Merged
Issues 159 and 160 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dropdown sometimes showed even though no view tab was overflowing - this because the adjusted viewport width was not yet flushed to the DOM when checking for overflowing view tabs. fixes #159
…ng to the observable The request was immediately posted when invoking 'requestReceive$' method, which is wrong. Instead, it is now posted upon subscription. It is unlike the 'requestReply' method, which starts resolving the promise immediately. fixes: #160
ReToCode
previously approved these changes
Jul 26, 2019
danielwiehl
force-pushed
the
issue/159_160
branch
from
0ecf9ca to
937cdce
Compare
ReToCode
previously approved these changes
Jul 26, 2019
danielwiehl
force-pushed
the
issue/159_160
branch
from
937cdce to
3941be3
Compare
…ecified via options object
The injection token {USE_NATIVE_RESIZE_OBSERVER} can be provided to control if to use native resize observable by default.
The flag has no effect if not supported by the user agent, or if explicitly specified via options object when creating the resize observable.
fixes: #156
danielwiehl
force-pushed
the
issue/159_160
branch
from
3941be3 to
2fa2ac8
Compare
ReToCode
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue
Issue Number: #159 #160
Does this PR introduce a breaking change?
Other information