Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown with hidden view tabs shows without having view tabs overflowing the view tab bar #159

Closed
danielwiehl opened this issue Jul 25, 2019 · 0 comments
Closed

Dropdown with hidden view tabs shows without having view tabs overflowing the view tab bar #159

danielwiehl opened this issue Jul 25, 2019 · 0 comments
Assignees
@danielwiehl
Labels
bug comp: workbench

Comments

@danielwiehl
Copy link
Collaborator

danielwiehl commented Jul 25, 2019 •
edited
Loading

Current behavior

When opening a new view, the view tab bar sometimes shows the hidden view tab menu even if there is enough space for all view tabs.

Expected behavior

The dropdown shows only if there is not enough space for all view tabs.

Environment

  • SCION Workbench version:0.0.0-beta.24
  • Angular version: 8.x
@danielwiehl danielwiehl self-assigned this Jul 25, 2019
danielwiehl added a commit that referenced this issue Jul 26, 2019
@danielwiehl
fix: show the view dropdown only if some view tabs overflow
69782e2 
The dropdown sometimes showed even though no view tab was overflowing - this because the adjusted viewport width was not yet flushed to the DOM when checking for overflowing view tabs.

fixes #159
@danielwiehl danielwiehl mentioned this issue Jul 26, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielwiehl danielwiehl

Labels
bug comp: workbench
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielwiehl