feat(OnyxSelect, OnyxRadioGroup, OnyxCheckboxGroup): Implement truncation on higher level #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 261ccbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… Implement truncation on higher level
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: MajaZarkova <[email protected]>
BoppLi
reviewed
Jul 10, 2024
...ges/sit-onyx/playwright/snapshots/components/OnyxCheckbox/Checkbox-other--chromium-linux.png
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
BoppLi
requested changes
Jul 10, 2024
packages/sit-onyx/src/components/OnyxRadioButton/OnyxRadioButton.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxRadioButton/OnyxRadioButton.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxSelectOption/OnyxSelectOption.vue
Outdated
Show resolved
Hide resolved
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: MajaZarkova <[email protected]>
BoppLi
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1539
Up until now the truncation property was on option-level only for OnyxSelect, OnyxRadioGroup and OnyxCheckboxGroup. The user had to set the property for each option separately. In this PR, the truncation property is added to the grouped component too, so that the user can set the truncation only once for every option. This property is used only as a fallback if the truncation is not set on option-level.
Checklist
npx changeset addif your changes should be released as npm package (because they affect the library usage)