Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement truncation prop for OnyxCheckboxGroup, OnyxRadioGroup and OnyxSelect #1539

Closed
9 tasks done
MajaZarkova opened this issue Jul 10, 2024 · 0 comments
Closed
9 tasks done

Implement truncation prop for OnyxCheckboxGroup, OnyxRadioGroup and OnyxSelect #1539

MajaZarkova opened this issue Jul 10, 2024 · 0 comments
Assignees
@MajaZarkova
Labels
dev Requires technical expertise
Milestone
Selection controls

Comments

@MajaZarkova
Copy link
Contributor

MajaZarkova commented Jul 10, 2024 •
edited by BoppLi
Loading

Follow up on

Why?

Property truncation should be inherited from OnyxBaseSelectOption and be used as a fallback value, meaning if a truncation is not given on option level this value should be used for all options.

Acceptance criteria

  • Default value og truncation should be 'ellipsis'

Definition of Done

  • covered by component tests
  • screenshot tests are updated
  • follow-up tickets were created if necessary
  • updated version + documentation is deployed
  • Storybook can show the feature
  • Storybook code snippet of new/changed examples are checked that they are generated correctly
  • Namings are aligned with Figma

Approval

  • Storybook
  • approved by dev @BoppLi
@MajaZarkova MajaZarkova added this to onyx Jul 10, 2024
@MajaZarkova MajaZarkova converted this from a draft issue Jul 10, 2024
@MajaZarkova MajaZarkova self-assigned this Jul 10, 2024
@MajaZarkova MajaZarkova moved this from New to In Progress in onyx Jul 10, 2024
@MajaZarkova MajaZarkova moved this from In Progress to New in onyx Jul 10, 2024
@MajaZarkova MajaZarkova added the dev Requires technical expertise label Jul 10, 2024
@MajaZarkova MajaZarkova moved this from New to In Progress in onyx Jul 10, 2024
@MajaZarkova MajaZarkova mentioned this issue Jul 10, 2024
Merged
1 task
MajaZarkova added a commit that referenced this issue Jul 10, 2024
@MajaZarkova @github-actions
feat(OnyxSelect, OnyxRadioGroup, OnyxCheckboxGroup): Implement trunca…
67a5e50 
…tion on higher level (#1541)

<!-- Is your PR related to an issue? Then please link it via the
"Relates to #" below. Else, remove it. -->

Relates to #1539 

Up until now the truncation property was on option-level only for
OnyxSelect, OnyxRadioGroup and OnyxCheckboxGroup. The user had to set
the property for each option separately. In this PR, the truncation
property is added to the grouped component too, so that the user can set
the truncation only once for every option. This property is used only as
a fallback if the truncation is not set on option-level.

## Checklist

- [x] A changeset is added with `npx changeset add` if your changes
should be released as npm package (because they affect the library
usage)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in onyx Jul 10, 2024
@mj-hof mj-hof added this to the Selection controls milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MajaZarkova MajaZarkova

Labels
dev Requires technical expertise
Projects
onyx
Status: Done
Milestone
Selection controls
Development

No branches or pull requests
2 participants
@MajaZarkova @mj-hof