Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only init payjoin when payment network is bitcoin #374

Merged

Conversation

kumulynja
Copy link
Contributor

The first receive tab and network that seems to be loaded initially is Lightning. For this an amount has to be entered and no default invoice should be generated, so returning immediately in the updateWalletBloc function is added for Lightning.
And then this PR also adds a check to make sure to only init payjoin for the bitcoin network, this way we avoid the liquid address being used to init the payjoin.

@kumulynja
Copy link
Contributor Author

This should fix #370

@kumulynja
Copy link
Contributor Author

kumulynja commented Dec 23, 2024

@i5hi This seems to fix it, but I have a doubt though. I am checking on the payment network now to init payjoin or not.
Do you think it is maybe better to also base it on the wallet that is selected, making sure the secure onchain wallet is selected too, instead of just the network?

@mocodesmo mocodesmo merged commit 82a9986 into SatoshiPortal:main Dec 23, 2024
@kumulynja
Copy link
Contributor Author

@i5hi This seems to fix it, but I have a doubt though. I am checking on the payment network now to init payjoin or not. Do you think it is maybe better to also base it on the wallet that is selected, making sure the secure onchain wallet is selected too, instead of just the network?

As clarified by @i5hi and @ethicnology out-of-band, we should add a check for BaseWalletType.Bitcoin.

@ethicnology
Copy link
Collaborator

@i5hi This seems to fix it, but I have a doubt though. I am checking on the payment network now to init payjoin or not. Do you think it is maybe better to also base it on the wallet that is selected, making sure the secure onchain wallet is selected too, instead of just the network?

As clarified by @i5hi and @ethicnology out-of-band, we should add a check for BaseWalletType.Bitcoin.

#381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants