Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Payjoin Receive] initReceiver Error while creating receive URI #370

Closed
i5hi opened this issue Dec 22, 2024 · 5 comments
Closed

[Payjoin Receive] initReceiver Error while creating receive URI #370

i5hi opened this issue Dec 22, 2024 · 5 comments
Assignees
@mocodesmo @i5hi
Labels
urgent requires immediate attention

Comments

@i5hi
Copy link
Collaborator

i5hi commented Dec 22, 2024

initReceiver throws the following error when creating a Receive uri

_Exception (Exception: Error initializing payjoin Receiver: PayjoinException( Error while parsing the address: legacy address base58 string ))
@i5hi
Copy link
Collaborator Author

i5hi commented Dec 22, 2024

Note: This does not prevent the address from being created and displayed.

@i5hi
Copy link
Collaborator Author

i5hi commented Dec 22, 2024

legacy address base58 string

The address being used is bech32 segwit

@i5hi
Copy link
Collaborator Author

i5hi commented Dec 22, 2024

Seems like its using the liquid address.

We should not use the Instant Wallet for payjoins.

@i5hi i5hi assigned mocodesmo and unassigned ethicnology Dec 22, 2024
@i5hi i5hi changed the title [Payjoin Recieve] initReceiver Error while creating receive URI [Payjoin Receive] initReceiver Error while creating receive URI Dec 22, 2024
@i5hi i5hi added the urgent requires immediate attention label Dec 22, 2024
@kumulynja kumulynja mentioned this issue Dec 23, 2024
Merged
@kumulynja
Copy link
Contributor

@i5hi as mentioned in the PR that is already merged, maybe adding an extra check on the wallet type is also needed still instead of only the payment network, what do you think? Shall I add it before closing this issue completely?

@ethicnology ethicnology mentioned this issue Dec 23, 2024
Merged
@ethicnology
Copy link
Collaborator

Closed by #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mocodesmo mocodesmo

@i5hi i5hi

Labels
urgent requires immediate attention
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mocodesmo @i5hi @ethicnology @kumulynja