Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supply intermediate results (Q,I(Q)) for mixture as well as product #216

Merged
merged 3 commits into from
May 15, 2019

Conversation

pkienzle
Copy link
Contributor

Refs SasView/sasview#1301.

This supplies intermediates with Q, I(Q) for mixture and product models as a hierarchical ordered dictionary. Q may be [q] or [qx, qy]. Includes scalar radius_effective in product results.

This patch needs to be coordinated with the Qt GUI version. Modify as needed for the needs of Qt, while preserving the interface to Sasview.calc_composition_models.

@RichardHeenan
Copy link
Contributor

Think we need to merge this asap. But should this first be merged with the Ticket 1257 vesicle PR ?

I tried some simple tests in 5.0 for sphere times hardsphere and got same chi squared as expected from the normal fitpage P(Q)S(Q) compared to a plugin version.

@rozyczko rozyczko self-assigned this Apr 24, 2019
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dicts in >=3.6 are ordered by default, not sure what your requirements for sasmodels is in terms of python versioning.
Other than that looks good and ready for merge.

@rozyczko rozyczko merged commit 2517138 into master May 15, 2019
@pkienzle pkienzle deleted the sasview-1301-mixture-results branch May 23, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants