Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5 & v4 TEst that P(Q)S(Q) plugin works #1478

Closed
RichardHeenan opened this issue Mar 18, 2020 · 3 comments
Closed

v5 & v4 TEst that P(Q)S(Q) plugin works #1478

RichardHeenan opened this issue Mar 18, 2020 · 3 comments
Assignees
@RichardHeenan
Labels
Minor Small job Plotting Concerns plotting functionality
Milestone
SasView 5.0.3

Comments

@RichardHeenan
Copy link
Contributor

From #1470, spawn this ...

P(Q)S(Q) plugin not working ??? - needs test
#1301
#1451 which was merged to master of sasmodels - see SasView/sasmodels#216
@RichardHeenan RichardHeenan added Minor Small job Plotting Concerns plotting functionality labels Mar 18, 2020
@RichardHeenan RichardHeenan added this to the SasView 5.0.2 milestone Mar 18, 2020
@RichardHeenan RichardHeenan self-assigned this Mar 18, 2020
@smk78 smk78 mentioned this issue Mar 18, 2020
Open
@butlerpd butlerpd modified the milestones: SasView 5.0.2, SasView 5.0.3 Mar 31, 2020
@butlerpd
Copy link
Member

As per today's discussion, moving this to a 5.0.3 milestone in preparation for a 5.0.2 release.
However as I read this it is just a test. passing the test closes the issue and presumably the issue it is tied to while and failing presumably leads to comments on the issue/PR in question?

@butlerpd
Copy link
Member

Not clear where this should go or be closed but will move to 5.0.4 for now

@butlerpd butlerpd modified the milestones: SasView 5.0.3, SasView 5.0.4 Aug 18, 2020
@RichardHeenan
Copy link
Contributor Author

P(Q)S(Q) plugin It is working in 5.0.3 at least for ellipsoid x hard_sphere which I tested it on, (though of course radius_effective in S(Q) is not constrained), and I am not concerned re v4, so will close this ticket.

@butlerpd butlerpd modified the milestones: SasView 5.0.4, SasView 5.0.3 Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RichardHeenan RichardHeenan

Labels
Minor Small job Plotting Concerns plotting functionality
Projects
None yet
Milestone
SasView 5.0.3
Development

No branches or pull requests
2 participants
@RichardHeenan @butlerpd