meta: const string implementation #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeletier
force-pushed
the
const-string
branch
6 times, most recently
from
06274ac
to
08646c4
Compare
jpeletier
force-pushed
the
const-string
branch
from
08646c4
to
4677f92
Compare
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Includes #1313, so that the tests would pass. It might make sense to review and merge that one first.
This PR implements an opaque type to represent read-only const strings stored in .rodata, so that the automatic destructor I am working on to fix #1215 ignores them, since no destructor is specified for this opaque type.
The PR also maps
build_info_t's reflection definition to use these const strings.In conjunction with #1316, const strings are then more or less transparent from the reflection/cursor point of view. A cursor can read a const string, but won't be able to write to it, since it does not implement
assign_stringoverload.