Fix some flaky test in meta/ SerializeEntityToJson #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
regex not available in windows builds. I'll be back... |
|
fixed! |
jpeletier
force-pushed
the
flaky-serialize-json
branch
from
3fa3a1c
to
8432cfd
Compare
jpeletier
force-pushed
the
flaky-serialize-json
branch
2 times, most recently
from
a6addec
to
4c24265
Compare
jpeletier
force-pushed
the
flaky-serialize-json
branch
from
4c24265
to
826e674
Compare
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1215 I noticed some tests of the meta add-on would not pass due to varying entity ids and for alerts, the order of alerts.
So I fixed two tests. For the first one, I gave entities fixed names so we would not be testing against entity ids which can vary.
For the second test, it is more complicated to make it perfect without a JSON library. The order of alerts in the alerts array is of undetermined order, causing the test to fail depending on arbitrary code changes elsewhere, Therefore I wrote an approximation searching for substrings to find the expected alerts in a deterministic way. This should be good enough I think.