Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: container for images #159

Merged
merged 7 commits into from
Apr 4, 2023
Merged

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Apr 4, 2023

Closes #158.

Summary of Changes

  • New class safeds.data.image.containers.Image to store images
  • An Image can be created from and saved to JPEG and PNG files
  • Methods that create a plot for Table and Column now return an Image instead of plotting them directly in an interactive environment
  • An Image can be displayed in an interactive environment

@lars-reimann lars-reimann linked an issue Apr 4, 2023 that may be closed by this pull request
@lars-reimann lars-reimann requested a review from a team as a code owner April 4, 2023 13:45
@lars-reimann
Copy link
Member Author

lars-reimann commented Apr 4, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 14 0 0 1.08s
✅ PYTHON mypy 14 0 2.47s
✅ PYTHON ruff 14 0 0 0.06s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #159 (045bac9) into main (26eee03) will decrease coverage by 0.20%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   93.51%   93.32%   -0.20%     
==========================================
  Files          36       40       +4     
  Lines        1373     1453      +80     
==========================================
+ Hits         1284     1356      +72     
- Misses         89       97       +8     
Impacted Files Coverage Δ
src/safeds/data/tabular/containers/_row.py 81.66% <ø> (ø)
...rc/safeds/data/tabular/containers/_tagged_table.py 72.22% <ø> (ø)
src/safeds/data/image/containers/_image.py 80.48% <80.48%> (ø)
src/safeds/data/image/containers/__init__.py 100.00% <100.00%> (ø)
src/safeds/data/image/typing/__init__.py 100.00% <100.00%> (ø)
src/safeds/data/image/typing/_image_format.py 100.00% <100.00%> (ø)
src/safeds/data/tabular/containers/_column.py 89.86% <100.00%> (+0.97%) ⬆️
src/safeds/data/tabular/containers/_table.py 92.94% <100.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann lars-reimann merged commit ed7ae34 into main Apr 4, 2023
@lars-reimann lars-reimann deleted the 158-create-a-class-to-hold-image-data branch April 4, 2023 14:03
lars-reimann pushed a commit that referenced this pull request Apr 4, 2023
## [0.9.0](v0.8.0...v0.9.0) (2023-04-04)

### Features

* container for images ([#159](#159)) ([ed7ae34](ed7ae34)), closes [#158](#158)
* improve error handling for `predict` ([#145](#145)) ([a5ff11c](a5ff11c)), closes [#9](#9)
* move `ImputerStrategy` to `safeds.data.tabular.typing` ([#174](#174)) ([205c8e2](205c8e2))
* rename `n_neighbors` to `number_of_neighbors` ([#162](#162)) ([526b96e](526b96e))

### Bug Fixes

* export `TableTransformer` and `InvertibleTableTransformer` ([#135](#135)) ([81c3695](81c3695))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a class to hold image data
2 participants