Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test output of plotting methods #175

Closed
lars-reimann opened this issue Apr 4, 2023 · 1 comment · Fixed by #239
Closed

Test output of plotting methods #175

lars-reimann opened this issue Apr 4, 2023 · 1 comment · Fixed by #239
Assignees
@PhilipGutberlet @patrikguempel
Labels
good first issue Good for newcomers released Included in a release testing 🧪 Additional automated tests

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Apr 4, 2023 •
edited
Loading

The tests for the plotting methods

  • Column.boxplot
  • Column.histogram
  • Table.correlation_heatmap
  • Table.lineplot
  • Table.scatterplot

are insufficient. Now that the plotting methods return an Image (#159), we can test them more thoroughly:

  1. Write test code that calls the plotting method on some simple data.
  2. Store the output in a PNG file in tests/resources/image.
  3. Put the test code into a pytest function to compute the current output of the plotting method.
  4. Load the image file to get the expected output.
  5. Assert that the images are equal.

This way we can easily detect regressions, e.g. when we update dependencies.
@lars-reimann lars-reimann added the testing 🧪 Additional automated tests label Apr 4, 2023
@lars-reimann lars-reimann added the good first issue Good for newcomers label Apr 13, 2023
@PhilipGutberlet PhilipGutberlet mentioned this issue Apr 21, 2023
Merged
@PhilipGutberlet PhilipGutberlet linked a pull request Apr 21, 2023 that will close this issue
test: snapshot tests for diagrams #239
Merged
lars-reimann added a commit that referenced this issue May 5, 2023
@PhilipGutberlet @megalinter-bot @lars-reimann
test: snapshot tests for diagrams (#239)
4bc4c09 
Closes #175.

### Summary of Changes
Created tests to check if there are any graphic changes in the seaborn
library by adding legacy graphics to compare to

Co-authored-by: patrikguempel
<[email protected]>

---------

Co-authored-by: megalinter-bot <[email protected]>
Co-authored-by: Lars Reimann <[email protected]>
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilipGutberlet PhilipGutberlet

@patrikguempel patrikguempel

Labels
good first issue Good for newcomers released Included in a release testing 🧪 Additional automated tests
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: snapshot tests for diagrams Safe-DS/Library
3 participants
@lars-reimann @PhilipGutberlet @patrikguempel