Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve ml tests #129

Merged
merged 5 commits into from
Mar 30, 2023
Merged

test: improve ml tests #129

merged 5 commits into from
Mar 30, 2023

Conversation

lars-reimann
Copy link
Member

Closes #116.
Closes #117.

Summary of Changes

  • Reduce code duplication
  • Test that fit doesn't change the input table
  • Test that predict doesn't change the input table

@lars-reimann lars-reimann requested a review from a team as a code owner March 30, 2023 20:03
@lars-reimann
Copy link
Member Author

lars-reimann commented Mar 30, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 0 0 0.61s
✅ PYTHON flake8 2 0 0.36s
✅ PYTHON isort 2 0 0 0.22s
✅ PYTHON mypy 2 0 1.53s
✅ PYTHON pylint 2 0 1.35s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #129 (a624465) into main (ddd3f59) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head a624465 differs from pull request most recent head eee1d9e. Consider uploading reports for the commit eee1d9e to get more accurate results

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   93.14%   93.22%   +0.07%     
==========================================
  Files          36       36              
  Lines        1254     1254              
==========================================
+ Hits         1168     1169       +1     
+ Misses         86       85       -1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann lars-reimann merged commit fa04186 into main Mar 30, 2023
@lars-reimann lars-reimann deleted the refactor_ml_tests branch March 30, 2023 20:07
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that fit does not change the input TaggedTable Check that predict does not change the input Table
1 participant