Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that fit does not change the input TaggedTable #117

Closed
lars-reimann opened this issue Mar 29, 2023 · 1 comment · Fixed by #129
Closed

Check that fit does not change the input TaggedTable #117

lars-reimann opened this issue Mar 29, 2023 · 1 comment · Fixed by #129
Assignees
@lars-reimann
Labels
good first issue Good for newcomers released Included in a release testing 🧪 Additional automated tests

Comments

@lars-reimann
Copy link
Member

We should ensure for all classifiers/regressors that their fit method does not change the input TaggedTable.
@lars-reimann lars-reimann added testing 🧪 Additional automated tests good first issue Good for newcomers labels Mar 29, 2023
@lars-reimann lars-reimann self-assigned this Mar 30, 2023
@lars-reimann lars-reimann mentioned this issue Mar 30, 2023
Merged
lars-reimann added a commit that referenced this issue Mar 30, 2023
@lars-reimann
test: improve ml tests (#129)
fa04186 
Closes #116.
Closes #117.

### Summary of Changes

* Reduce code duplication
* Test that `fit` doesn't change the input table
* Test that `predict` doesn't change the input table

---------

Co-authored-by: lars-reimann <[email protected]>
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
good first issue Good for newcomers released Included in a release testing 🧪 Additional automated tests
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: improve ml tests Safe-DS/Library
1 participant
@lars-reimann