Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method names of Table #439

Closed
lars-reimann opened this issue Jul 7, 2023 · 2 comments · Fixed by #445
Closed

Method names of Table #439

lars-reimann opened this issue Jul 7, 2023 · 2 comments · Fixed by #445
Assignees
@lars-reimann
Labels
cleanup 🧹 Refactorings and other tasks that improve the code released Included in a release

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Jul 7, 2023 •
edited
Loading

Is your feature request related to a problem?

Some method names of Table don't clarify whether they work on rows or on columns. Also, summary neither fits the from/to pattern nor does it start with a verb.

Desired solution

  • Rename group_by to group_rows_by
  • Rename split to split_rows
  • Rename summary to summarize_statistics
  • Also update the names of test files and the contained tests accordingly.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann added the cleanup 🧹 Refactorings and other tasks that improve the code label Jul 7, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Library Jul 7, 2023
@lars-reimann lars-reimann moved this from Backlog to 🧱 Blocked in Library Jul 7, 2023
@lars-reimann
Copy link
Member Author

Can be done after #332 is merged.

@zzril zzril moved this from 🧱 Blocked to Backlog in Library Jul 9, 2023
@lars-reimann lars-reimann self-assigned this Jul 11, 2023
@lars-reimann lars-reimann moved this from Backlog to In Progress in Library Jul 11, 2023
@lars-reimann lars-reimann linked a pull request Jul 11, 2023 that will close this issue
feat: rename several Table methods for consistency #445
Merged
@lars-reimann lars-reimann mentioned this issue Jul 11, 2023
Merged
lars-reimann added a commit that referenced this issue Jul 11, 2023
@lars-reimann
feat: rename several Table methods for consistency (#445)
9954986 
Closes #439

### Summary of Changes

* Rename `group_by` to `group_rows_by`
* Rename `split` to `split_rows`
* Rename `summary` to `summarize_statistics`
@github-project-automation github-project-automation bot moved this from In Progress to ✔️ Done in Library Jul 11, 2023
lars-reimann pushed a commit that referenced this issue Jul 13, 2023
@semantic-release-bot
chore(release): 0.15.0 [skip ci]
a52bc18 
## [0.15.0](v0.14.0...v0.15.0) (2023-07-13)

### Features

* Add copy method for tables ([#405](#405)) ([72e87f0](72e87f0)), closes [#275](#275)
* add gaussian noise to image ([#430](#430)) ([925a505](925a505)), closes [#381](#381)
* add schema conversions when adding new rows to a table and schema conversion when creating a new table ([#432](#432)) ([6e9ff69](6e9ff69)), closes [#404](#404) [#322](#322) [#127](#127) [#322](#322) [#127](#127)
* add test for empty tables for the method `Table.sort_rows` ([#431](#431)) ([f94b768](f94b768)), closes [#402](#402)
* added color adjustment feature ([#409](#409)) ([2cbee36](2cbee36)), closes [#380](#380)
* added test_repr table tests ([#410](#410)) ([cb77790](cb77790)), closes [#349](#349)
* discretize table ([#327](#327)) ([5e3da8d](5e3da8d)), closes [#143](#143)
* Improve error handling of TaggedTable ([#450](#450)) ([c5da544](c5da544)), closes [#150](#150)
* Maintain tagging in methods inherited from `Table` class ([#332](#332)) ([bc73a6c](bc73a6c)), closes [#58](#58)
* new error class `OutOfBoundsError` ([#438](#438)) ([1f37e4a](1f37e4a)), closes [#262](#262)
* rename several `Table` methods for consistency ([#445](#445)) ([9954986](9954986)), closes [#439](#439)
* suggest similar columns if column gets accessed that doesnt exist ([#385](#385)) ([6a097a4](6a097a4)), closes [#203](#203)

### Bug Fixes

* added the missing ids in parameterized tests ([#412](#412)) ([dab6419](dab6419)), closes [#362](#362)
* don't warn if `Imputer` transforms column without missing values ([#448](#448)) ([f0cb6a5](f0cb6a5))
* Warnings raised by underlying seaborn and numpy libraries  ([#425](#425)) ([c4143af](c4143af)), closes [#357](#357)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
cleanup 🧹 Refactorings and other tasks that improve the code released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rename several Table methods for consistency Safe-DS/Library
1 participant
@lars-reimann