Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change test for empty table for the method Table.sort_rows #402

Closed
Marsmaennchen221 opened this issue Jun 30, 2023 · 1 comment · Fixed by #431
Closed

Change test for empty table for the method Table.sort_rows #402

Marsmaennchen221 opened this issue Jun 30, 2023 · 1 comment · Fixed by #431
Assignees
@robmeth
Labels
released Included in a release testing 🧪 Additional automated tests

Comments

@Marsmaennchen221
Copy link
Contributor

Is your feature request related to a problem?

The test file for Table.sort_rows contains two comments mentioning that we should implement a check for empty table after #75 is fixed. We do have a test in the file that tests wether an empty Table is equal to a sorted empty Table.

Desired solution

  1. Remove the comments
  2. (Optional) You could implement the test for empty table in the tests for non empty tables. There is no need to test the behaviour in a seperate test.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@github-project-automation github-project-automation bot moved this to Backlog in Library Jun 30, 2023
@lars-reimann lars-reimann added testing 🧪 Additional automated tests and removed enhancement 💡 labels Jun 30, 2023
@daniaHu daniaHu moved this from Backlog to Todo in Library Jun 30, 2023
@robmeth robmeth self-assigned this Jul 7, 2023
@robmeth robmeth moved this from Todo to In Progress in Library Jul 7, 2023
@robmeth robmeth linked a pull request Jul 7, 2023 that will close this issue
feat: add test for empty tables for the method Table.sort_rows #431
Merged
@robmeth robmeth mentioned this issue Jul 7, 2023
Merged
@robmeth robmeth moved this from In Progress to Ready for Review in Library Jul 7, 2023
robmeth added a commit that referenced this issue Jul 7, 2023
@robmeth
feat: add test for empty tables for the method Table.sort_rows (#431)
f94b768 
Closes #402

### Summary of Changes

implement the test for empty table in the tests for non empty tables.
@github-project-automation github-project-automation bot moved this from Ready for Review to ✔️ Done in Library Jul 7, 2023
lars-reimann pushed a commit that referenced this issue Jul 13, 2023
@semantic-release-bot
chore(release): 0.15.0 [skip ci]
a52bc18 
## [0.15.0](v0.14.0...v0.15.0) (2023-07-13)

### Features

* Add copy method for tables ([#405](#405)) ([72e87f0](72e87f0)), closes [#275](#275)
* add gaussian noise to image ([#430](#430)) ([925a505](925a505)), closes [#381](#381)
* add schema conversions when adding new rows to a table and schema conversion when creating a new table ([#432](#432)) ([6e9ff69](6e9ff69)), closes [#404](#404) [#322](#322) [#127](#127) [#322](#322) [#127](#127)
* add test for empty tables for the method `Table.sort_rows` ([#431](#431)) ([f94b768](f94b768)), closes [#402](#402)
* added color adjustment feature ([#409](#409)) ([2cbee36](2cbee36)), closes [#380](#380)
* added test_repr table tests ([#410](#410)) ([cb77790](cb77790)), closes [#349](#349)
* discretize table ([#327](#327)) ([5e3da8d](5e3da8d)), closes [#143](#143)
* Improve error handling of TaggedTable ([#450](#450)) ([c5da544](c5da544)), closes [#150](#150)
* Maintain tagging in methods inherited from `Table` class ([#332](#332)) ([bc73a6c](bc73a6c)), closes [#58](#58)
* new error class `OutOfBoundsError` ([#438](#438)) ([1f37e4a](1f37e4a)), closes [#262](#262)
* rename several `Table` methods for consistency ([#445](#445)) ([9954986](9954986)), closes [#439](#439)
* suggest similar columns if column gets accessed that doesnt exist ([#385](#385)) ([6a097a4](6a097a4)), closes [#203](#203)

### Bug Fixes

* added the missing ids in parameterized tests ([#412](#412)) ([dab6419](dab6419)), closes [#362](#362)
* don't warn if `Imputer` transforms column without missing values ([#448](#448)) ([f0cb6a5](f0cb6a5))
* Warnings raised by underlying seaborn and numpy libraries  ([#425](#425)) ([c4143af](c4143af)), closes [#357](#357)
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robmeth robmeth

Labels
released Included in a release testing 🧪 Additional automated tests
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add test for empty tables for the method Table.sort_rows Safe-DS/Library
3 participants
@lars-reimann @Marsmaennchen221 @robmeth