Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added MissingDataError + Data processing tutorial #406

Merged
merged 7 commits into from
Feb 1, 2023

Conversation

Marsmaennchen221
Copy link
Contributor

@Marsmaennchen221 Marsmaennchen221 commented Feb 1, 2023

Related to Issue #380

Summary of Changes

Added a new data processing tutorial

from_rows and from_columns now raise a MissingDataError if the provided lists of rows/columns are empty
if none of the rows of a table in filter_rows match with the query the function now returns an empty table with the same schema as the original table

`from_rows` and `from_columns` now raise an `MissingDataError` if the provided lists of rows/columns are empty
if none of the rows of a table in `filter_rows` match with the query the function now returns an empty table with the same schema as the original table
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #406 (3a744ae) into main (3162a66) will increase coverage by 0.01%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   80.77%   80.78%   +0.01%     
==========================================
  Files         180      180              
  Lines        6403     6412       +9     
  Branches     1293     1293              
==========================================
+ Hits         5172     5180       +8     
- Misses        856      857       +1     
  Partials      375      375              
Impacted Files Coverage Δ
Runtime/safe-ds/safeds/exceptions/__init__.py 100.00% <ø> (ø)
Runtime/safe-ds/safeds/data/tabular/_table.py 91.28% <85.71%> (-0.17%) ⬇️
...time/safe-ds/safeds/exceptions/_data_exceptions.py 96.29% <100.00%> (+0.46%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ MARKDOWN markdown-link-check 1 0 0.41s
✅ PYTHON bandit 5 0 0.65s
✅ PYTHON black 5 0 0 0.82s
✅ PYTHON flake8 5 0 0.51s
✅ PYTHON isort 5 0 0 0.28s
✅ PYTHON mypy 5 0 2.11s
✅ PYTHON pylint 5 0 2.87s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Marsmaennchen221 Marsmaennchen221 changed the title doc: Data processing tutorial docs: Data processing tutorial Feb 1, 2023
@Marsmaennchen221
Copy link
Contributor Author

I'm not sure if "docs:" in the title is the right type since I also added an Exception Class and altered three methods in the Table class

@WinPlay02 WinPlay02 changed the title docs: Data processing tutorial feat: Added MissingDataError + Data processing tutorial Feb 1, 2023
Copy link
Contributor

@WinPlay02 WinPlay02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit unsure about the capitalization of Row, Table, Column, etc.
I suggested some changes, but left the capitalization unchanged as it can be useful in most of the cases.

Runtime/safe-ds/safeds/data/tabular/_table.py Outdated Show resolved Hide resolved
Runtime/safe-ds/safeds/data/tabular/_table.py Outdated Show resolved Hide resolved
Runtime/safe-ds/safeds/exceptions/_data_exceptions.py Outdated Show resolved Hide resolved
docs/Stdlib/python/Tutorials/data_processing.md Outdated Show resolved Hide resolved
docs/Stdlib/python/Tutorials/data_processing.md Outdated Show resolved Hide resolved
docs/Stdlib/python/Tutorials/data_processing.md Outdated Show resolved Hide resolved
docs/Stdlib/python/Tutorials/data_processing.md Outdated Show resolved Hide resolved
docs/Stdlib/python/Tutorials/data_processing.md Outdated Show resolved Hide resolved
docs/Stdlib/python/Tutorials/data_processing.md Outdated Show resolved Hide resolved
docs/Stdlib/python/Tutorials/data_processing.md Outdated Show resolved Hide resolved
@WinPlay02
Copy link
Contributor

Alright. In that case your suggestions are fine.

Co-authored-by: Marsmaennchen221 <[email protected]>
Copy link
Contributor

@WinPlay02 WinPlay02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still one conversation remaining

@Marsmaennchen221 Marsmaennchen221 merged commit 9a06181 into main Feb 1, 2023
@Marsmaennchen221 Marsmaennchen221 deleted the data_processing_tutorial branch February 1, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants