-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added MissingDataError + Data processing tutorial #406
Conversation
`from_rows` and `from_columns` now raise an `MissingDataError` if the provided lists of rows/columns are empty if none of the rows of a table in `filter_rows` match with the query the function now returns an empty table with the same schema as the original table
…ata_processing_tutorial
Codecov Report
@@ Coverage Diff @@
## main #406 +/- ##
==========================================
+ Coverage 80.77% 80.78% +0.01%
==========================================
Files 180 180
Lines 6403 6412 +9
Branches 1293 1293
==========================================
+ Hits 5172 5180 +8
- Misses 856 857 +1
Partials 375 375
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
I'm not sure if "docs:" in the title is the right type since I also added an Exception Class and altered three methods in the Table class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit unsure about the capitalization of Row, Table, Column, etc.
I suggested some changes, but left the capitalization unchanged as it can be useful in most of the cases.
Co-authored-by: WinPlay02 <[email protected]>
Alright. In that case your suggestions are fine. |
Co-authored-by: Marsmaennchen221 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still one conversation remaining
Co-authored-by: WinPlay02 <[email protected]>
Related to Issue #380
Summary of Changes
Added a new data processing tutorial
from_rows
andfrom_columns
now raise aMissingDataError
if the provided lists of rows/columns are emptyif none of the rows of a table in
filter_rows
match with the query the function now returns an empty table with the same schema as the original table