Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eda table right click improvements #1213

Merged
merged 26 commits into from
Jun 24, 2024

Conversation

SmiteDeluxe
Copy link
Contributor

Closes #1180

Summary of Changes

(Includes History PR changes)

  • Submenus in column right click:
    • "From Selection" if one or two selected => plot from selected columns or hide from selection
    • "From Click" that plots one column plots on current right clicked columns and hides column
  • "From Selection" also possible if right click on cells
  • All plotting now checks for column type where only numerical is allowed and shows greyed out with tooltip incl. reason if not possible
  • Right clicks if preventClicks is true only allowed if on same element type, so can change position of same right click by doing it again
  • With hiding mult cols from selection the toggleHideColumn method now takes array and only does it if all columns have same hidden state; for now adds separate history entries as creating a new action type for this would be too much

@SmiteDeluxe SmiteDeluxe added enhancement 💡 New feature or request vscode 🔨 Issues regarding tools like the VS Code extension labels Jun 21, 2024
@SmiteDeluxe SmiteDeluxe linked an issue Jun 21, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jun 21, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JSON prettier 1 0 0 1.51s
✅ REPOSITORY git_diff yes no 0.15s
✅ TSX eslint 1 0 0 5.74s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (597672b) to head (5bcd7e4).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1213   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files         110      110           
  Lines       19247    19247           
  Branches     4110     4110           
=======================================
  Hits        19207    19207           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The context-menu on the header of the ids column no longer works for the following program:

package demo

pipeline whoSurvived {
    val a = Table({"ids": [1, 2, 3]});
}

Plot Histogram and Plot Boxplot no longer do anything. It still seems to work for tables with multiple columns.

@SmiteDeluxe
Copy link
Contributor Author

@lars-reimann fixed! That annoying thing of !0 evaluating to true ...

Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lars-reimann lars-reimann merged commit cf440e3 into main Jun 24, 2024
7 checks passed
@lars-reimann lars-reimann deleted the 1180-eda-table-right-click-improvements branch June 24, 2024 14:32
lars-reimann pushed a commit that referenced this pull request Sep 25, 2024
## [0.18.0](v0.17.0...v0.18.0) (2024-09-25)

### Features

* eda history basic setup ([#1212](#1212)) ([597672b](597672b)), closes [#1211](#1211)
* eda refresh outdated view ([#1215](#1215)) ([2295d80](2295d80)), closes [#1214](#1214)
* **eda:** filter by column ([#1217](#1217)) ([77ad26c](77ad26c)), closes [#1216](#1216)
* integrate version 0.28.0 of the `safe-ds` Python library ([#1237](#1237)) ([1b742e7](1b742e7))
* select path for runner when installing ([#1238](#1238)) ([3d9d4db](3d9d4db)), closes [#1144](#1144)

### Bug Fixes

* eda table right click improvements ([#1213](#1213)) ([cf440e3](cf440e3)), closes [#1180](#1180)
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💡 New feature or request released Included in a release vscode 🔨 Issues regarding tools like the VS Code extension
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

EDA: table right click improvements
2 participants