-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: eda table right click improvements #1213
Conversation
…-click-improvements
& fix: dont open new context menu if $prevent clicks and currentMenu open not already the same one, thus allowing repositioning of same context menu
…-click-improvements
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1213 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 110 110
Lines 19247 19247
Branches 4110 4110
=======================================
Hits 19207 19207
Misses 40 40 ☔ View full report in Codecov by Sentry. |
…-click-improvements
…-click-improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The context-menu on the header of the ids
column no longer works for the following program:
package demo
pipeline whoSurvived {
val a = Table({"ids": [1, 2, 3]});
}
Plot Histogram
and Plot Boxplot
no longer do anything. It still seems to work for tables with multiple columns.
@lars-reimann fixed! That annoying thing of !0 evaluating to true ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
## [0.18.0](v0.17.0...v0.18.0) (2024-09-25) ### Features * eda history basic setup ([#1212](#1212)) ([597672b](597672b)), closes [#1211](#1211) * eda refresh outdated view ([#1215](#1215)) ([2295d80](2295d80)), closes [#1214](#1214) * **eda:** filter by column ([#1217](#1217)) ([77ad26c](77ad26c)), closes [#1216](#1216) * integrate version 0.28.0 of the `safe-ds` Python library ([#1237](#1237)) ([1b742e7](1b742e7)) * select path for runner when installing ([#1238](#1238)) ([3d9d4db](3d9d4db)), closes [#1144](#1144) ### Bug Fixes * eda table right click improvements ([#1213](#1213)) ([cf440e3](cf440e3)), closes [#1180](#1180)
🎉 This PR is included in version 0.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #1180
Summary of Changes
(Includes History PR changes)