fix: generation of dynamic member function calls with memoization + propagating of impurity information across chained calls #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 99 99
Lines 18891 18915 +24
Branches 3879 3885 +6
=========================================
+ Hits 18891 18915 +24 ☔ View full report in Codecov by Sentry. |
lars-reimann
reviewed
Apr 9, 2024
lars-reimann
approved these changes
Apr 9, 2024
lars-reimann
pushed a commit
that referenced
this pull request
Apr 10, 2024
## [0.11.0](v0.10.0...v0.11.0) (2024-04-10) ### Features * add `toFloat` methods for `Int` and `String` ([#1018](#1018)) ([55a2050](55a2050)) * fine-grained control over inlay hints for parameter names ([#1016](#1016)) ([2667caf](2667caf)) * messaging service ([#1004](#1004)) ([dcf4ecf](dcf4ecf)) * semantic highlighting of block lambda results ([#1011](#1011)) ([228733c](228733c)) * start runner in language server ([#1006](#1006)) ([ef4bb6f](ef4bb6f)) * stubs for int conversions ([#1008](#1008)) ([b635f5a](b635f5a)) * support relative paths ([#1019](#1019)) ([3d3f28d](3d3f28d)) * trigger EDA tool via code lenses ([#1010](#1010)) ([eb6e4b6](eb6e4b6)) ### Bug Fixes * consumption of source maps ([#1005](#1005)) ([ea3da87](ea3da87)) * disable global EDA panel cache ([#1014](#1014)) ([f888027](f888027)), closes [/github.com//issues/986#issuecomment-2042731653](https://github.com/Safe-DS//github.com/Safe-DS/DSL/issues/986/issues/issuecomment-2042731653) * generation of dynamic member function calls with memoization + propagating of impurity information across chained calls ([#1015](#1015)) ([19015c3](19015c3)), closes [#1012](#1012) [#1013](#1013) * only spawn one runner process and shut it down properly ([#1009](#1009)) ([2c72cee](2c72cee)) * show EDA tool for `TaggedTable` and `TimeSeries` ([#1017](#1017)) ([ffae98a](ffae98a))
|
🎉 This PR is included in version 0.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1012
closes #1013
Summary of Changes
The new
memoized_dynamic_callis introduced +memoized_static_callis used for global and static functions.Calculating global / static function keys directly in the runner would be a larger refactor and is not implemented here.
As there is no dynamic dispatch / inheritance for global / static functions, this is not (as) important.
As a drive-by-fix, python calls on class members are now properly memoized, including the instance the python call was declared on.
The code is also refactored to be a bit simpler, as the
memoized_dynamic_callfunction defers some of the responsibility to the runner.