Skip to content

Commit

Permalink
fix: show EDA tool for TaggedTable and TimeSeries (#1017)
Browse files Browse the repository at this point in the history
### Summary of Changes

The EDA tool does it own additional type checking to ensure it only
opens on `Table`s. This should be removed eventually and type checking
should be fully delegated to the language server. For now, this PR also
allows opening it on `TaggedTable` and `TimeSeries`.
  • Loading branch information
lars-reimann authored Apr 9, 2024
1 parent 2667caf commit ffae98a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion packages/safe-ds-vscode/src/extension/mainClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,10 @@ const runEda = function (
);
if (
message.id === pipelineExecutionId &&
message.data.type === 'Table' &&
// Can be removed altogether if the EDA tool is only triggered via code lenses
(message.data.type === 'Table' ||
message.data.type === 'TaggedTable' ||
message.data.type === 'TimeSeries') &&
message.data.name === requestedPlaceholderName
) {
lastFinishedPipelineExecutionId = pipelineExecutionId;
Expand Down

0 comments on commit ffae98a

Please sign in to comment.