VS Code: Semantic highlighting #27
Assignees
Labels
enhancement 💡
New feature or request
released
Included in a release
vscode 🔨
Issues regarding tools like the VS Code extension
Comments
lars-reimann
added
vscode 🔨
lars-reimann
added
dsl 🗒️
lars-reimann
added a commit
that referenced
this issue
Oct 20, 2023
Closes #27 ### Summary of Changes Add semantic highlighting for declaration names and names used in cross-references. --------- Co-authored-by: megalinter-bot <[email protected]>
lars-reimann
pushed a commit
that referenced
this issue
Oct 25, 2023
## [0.2.0](v0.1.0...v0.2.0) (2023-10-25) ### Features * `const` modifier to replace `@Constant` annotation ([#618](#618)) ([ea4a9ba](ea4a9ba)), closes [#558](#558) * allow instance and static members of classes to have the same name ([#583](#583)) ([1b04905](1b04905)) * automatic formatting in Langium ([#526](#526)) ([922af22](922af22)), closes [#31](#31) [#33](#33) [#513](#513) [#433](#433) * basic implementation of partial evaluator service ([#649](#649)) ([10ed8bf](10ed8bf)), closes [#603](#603) * built-in library ([#557](#557)) ([7998eb1](7998eb1)), closes [#433](#433) * check `@PythonName` and `@PythonModule` ([#641](#641)) ([5a9dcbb](5a9dcbb)), closes [#543](#543) * check context of union types ([#677](#677)) ([e846b59](e846b59)), closes [#675](#675) * check template expressions inside `@PythonCall` ([#686](#686)) ([09bfb38](09bfb38)) * comment provider ([#688](#688)) ([e4a1b35](e4a1b35)), closes [#669](#669) * compute types of lambdas that are passed as arguments ([#604](#604)) ([25c8707](25c8707)), closes [#541](#541) * document symbol provider ([#659](#659)) ([fe0c8d5](fe0c8d5)) * documentation provider ([#689](#689)) ([ff70b07](ff70b07)), closes [#669](#669) * ensure that all assignees get a value ([#630](#630)) ([e8e2bf6](e8e2bf6)), closes [#543](#543) * error if @pythonName and @PythonCall are set on a function ([#685](#685)) ([d22c446](d22c446)) * error if argument lists are missing ([#642](#642)) ([f5ee1bd](f5ee1bd)), closes [#543](#543) * error if class or enum are statically referenced ([#643](#643)) ([8b076e7](8b076e7)), closes [#543](#543) * error if divisor is zero ([#644](#644)) ([9af3b81](9af3b81)), closes [#543](#543) * error if function pointers are used ([#629](#629)) ([01933b9](01933b9)), closes [#565](#565) [#543](#543) * error if lambda is used in wrong context ([#647](#647)) ([2d2ccc6](2d2ccc6)), closes [#409](#409) [#543](#543) * error if left operand of type parameter constraint does not belong to declaration with constraint ([#571](#571)) ([cba3abf](cba3abf)), closes [#562](#562) * error if member access must be null safe but isn't ([#626](#626)) ([077daff](077daff)), closes [#543](#543) * error if names are not unique (part 2) ([#640](#640)) ([38d1181](38d1181)), closes [#543](#543) * error if pipeline file is in a `safeds.xy` package ([#673](#673)) ([867bae3](867bae3)), closes [#671](#671) * error if placeholder is alias for parameter or placeholder ([#628](#628)) ([b99ab25](b99ab25)), closes [#564](#564) [#543](#543) * error if simple names of builtin declarations collide ([#678](#678)) ([275ad5e](275ad5e)), closes [#672](#672) * error if single use annotations are used multiple times ([#631](#631)) ([17a5b7a](17a5b7a)), closes [#543](#543) * error if type parameters don't have sufficient context ([#687](#687)) ([ea8fe29](ea8fe29)) * error if value assigned to constant parameters is not constant ([#646](#646)) ([097764d](097764d)), closes [#543](#543) * error if wildcard import has alias ([#574](#574)) ([4ba7873](4ba7873)), closes [#543](#543) * extensions for the `NodeMapper` ([#606](#606)) ([4fd8d86](4fd8d86)) * generation ([#634](#634)) ([c52b5e6](c52b5e6)), closes [#542](#542) * handle backticks surrounding IDs ([#622](#622)) ([608e470](608e470)), closes [#579](#579) * improved TextMate grammar ([#623](#623)) ([d7ff0e2](d7ff0e2)) * info if elvis operator is unnecessary ([#645](#645)) ([dcc05ce](dcc05ce)), closes [#543](#543) * info if import alias can be removed ([#637](#637)) ([83936b8](83936b8)), closes [#636](#636) * inlay hint provider ([#683](#683)) ([f23fa29](f23fa29)), closes [#679](#679) * intermediate type computer ([#600](#600)) ([8d68a42](8d68a42)), closes [#541](#541) * Langium grammar ([#470](#470)) ([c439c19](c439c19)), closes [#433](#433) * list & map literals ([#619](#619)) ([e3b2870](e3b2870)), closes [#615](#615) [#616](#616) * mark union types as experimental ([#676](#676)) ([4656c25](4656c25)), closes [#674](#674) * node mapper ([#602](#602)) ([a13e5b5](a13e5b5)) * port additional checks ([#567](#567)) ([2803305](2803305)), closes [#543](#543) * port additional validation checks to `Langium ([#576](#576)) ([8f5d57a](8f5d57a)), closes [#543](#543) * port remaining validation infos that don't need partial evaluation ([#607](#607)) ([d53bda3](d53bda3)), closes [#543](#543) * port validation of parameter lists ([#573](#573)) ([bd73bc5](bd73bc5)), closes [#543](#543) * Python-like import syntax ([#598](#598)) ([4c61b8c](4c61b8c)) * PythonCall annotation ([#684](#684)) ([15114df](15114df)), closes [#617](#617) * remove star projection and use-site variance ([#597](#597)) ([928f487](928f487)) * remove type arguments from calls ([#581](#581)) ([3e88f02](3e88f02)) * resolve references to declarations in other files ([#586](#586)) ([6b30de5](6b30de5)), closes [#540](#540) * scoping for named types ([#563](#563)) ([a877f4c](a877f4c)), closes [#540](#540) * scoping for own members ([#611](#611)) ([43b276f](43b276f)), closes [#540](#540) * scoping for references to own static members ([#582](#582)) ([38afc07](38afc07)), closes [#540](#540) * scoping for type arguments ([#585](#585)) ([3da8dd0](3da8dd0)), closes [#540](#540) * scoping of annotation calls, type parameter constraints & yields ([#561](#561)) ([a510f2b](a510f2b)), closes [#540](#540) * scoping of arguments ([#601](#601)) ([6b486cd](6b486cd)), closes [#540](#540) * scoping of direct references to declarations in same file ([#580](#580)) ([491d7b0](491d7b0)), closes [#540](#540) * semantic highlighting ([#653](#653)) ([fe8c602](fe8c602)), closes [#27](#27) * show info if unnecessary syntax is used ([#566](#566)) ([c26d33a](c26d33a)), closes [#543](#543) * show info that empty constraint lists can be removed ([#572](#572)) ([af13e28](af13e28)), closes [#570](#570) * stop validation after lexing/parsing errors ([#662](#662)) ([ba1e9a8](ba1e9a8)) * syntax and formatting for literal types ([#529](#529)) ([32aca34](32aca34)), closes [#80](#80) * syntax highlighting in documentation comments ([#690](#690)) ([83364d3](83364d3)), closes [#669](#669) * unique names withing declarations ([#575](#575)) ([47ce782](47ce782)), closes [#543](#543) * validate package of imports ([#627](#627)) ([18641de](18641de)), closes [#543](#543) * validation for annotation target ([#670](#670)) ([fa7631d](fa7631d)), closes [#543](#543) * validation for results of segments ([#613](#613)) ([bf20c7c](bf20c7c)), closes [#543](#543) * validation for type arguments of named types ([#632](#632)) ([b72768c](b72768c)), closes [#543](#543) * value converter for strings & ints ([#655](#655)) ([aafa2e3](aafa2e3)) * various checks for annotations on parameters and results ([#625](#625)) ([e77037e](e77037e)), closes [#543](#543) * various checks for argument lists ([#648](#648)) ([d76e597](d76e597)), closes [#543](#543) * various checks for calls ([#638](#638)) ([e0fa032](e0fa032)), closes [#543](#543) * various checks related to inheritance ([#633](#633)) ([7ec746a](7ec746a)), closes [#543](#543) * various features related to literal types ([#657](#657)) ([1775705](1775705)), closes [#80](#80) * very basic type computer ([#596](#596)) ([b3d786c](b3d786c)), closes [#541](#541) * warn if deprecated/experimental declarations are used ([#608](#608)) ([9b5287c](9b5287c)), closes [#543](#543) [#540](#540) * warn if experimental language features are used ([#624](#624)) ([090fcc3](090fcc3)), closes [#108](#108) * warn if parameters or placeholders are unused ([#612](#612)) ([3a2e9cc](3a2e9cc)), closes [#543](#543) * warning if literal types or union types have duplicate entries ([#658](#658)) ([9ba9d20](9ba9d20)) ### Bug Fixes * CLI startup ([#560](#560)) ([4bde898](4bde898)) * duplicate error if annotation call has no argument list and lacks required parameters ([#650](#650)) ([4ba2c2c](4ba2c2c)) * mark map literals as experimental ([#656](#656)) ([ca47870](ca47870)) * resolution of references to declarations of wrong node type ([#599](#599)) ([6ae387a](6ae387a))
|
🎉 This issue has been resolved in version 0.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
lars-reimann
pushed a commit
that referenced
this issue
Feb 1, 2024
Bumps [mkdocs-glightbox](https://github.com/Blueswen/mkdocs-glightbox) from 0.3.6 to 0.3.7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Blueswen/mkdocs-glightbox/releases">mkdocs-glightbox's releases</a>.</em></p> <blockquote> <h2>mkdocs-glightbox-0.3.7</h2> <ul> <li>Supported custom background and shadow (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/27">#27</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/blueswen/mkdocs-glightbox/blob/main/CHANGELOG">mkdocs-glightbox's changelog</a>.</em></p> <blockquote> <p>mkdocs-glightbox-0.3.7 (2023-01-24)</p> <pre><code>* Supported custom background and shadow ([#27](blueswen/mkdocs-glightbox#27)) </code></pre> <p>mkdocs-glightbox-0.3.6 (2023-12-30)</p> <pre><code>* Modified width default to auto prevent zooming large image bug ([#21](blueswen/mkdocs-glightbox#21)) * Supported only enable glightbox with on-glb class in given page ([#28](blueswen/mkdocs-glightbox#28)) </code></pre> <p>mkdocs-glightbox-0.3.5 (2023-11-18)</p> <pre><code>* Supported compatibility with the privacy plugin of Material for MkDocs insiders ([#25](blueswen/mkdocs-glightbox#25)) </code></pre> <p>mkdocs-glightbox-0.3.4 (2023-04-25)</p> <pre><code>* Fixed regex bug: quote issue and empty alt issue ([#14](blueswen/mkdocs-glightbox#14) [#19](blueswen/mkdocs-glightbox#19)) </code></pre> <p>mkdocs-glightbox-0.3.3 (2023-04-20)</p> <pre><code>* Refactored processing logic with regex ([#14](blueswen/mkdocs-glightbox#14)) </code></pre> <p>mkdocs-glightbox-0.3.2 (2023-03-19)</p> <pre><code>* Supported image without extension ([#13](blueswen/mkdocs-glightbox#13)) </code></pre> <p>mkdocs-glightbox-0.3.1 (2022-11-22)</p> <pre><code>* Supported lightbox slide effect customization ([#8](blueswen/mkdocs-glightbox#8)) * Supported synchronized lightbox caption dark mode with Material for MkDocs ([#7](blueswen/mkdocs-glightbox#7)) * Supported glightbox built-in gallery feature ([#11](blueswen/mkdocs-glightbox#11)) * Supported skip image in the anchor tag </code></pre> <p>mkdocs-glightbox-0.3.0 (2022-09-29)</p> <pre><code>* Fixed width and height setting in config not working bug * Supported specific skip class ([#5](blueswen/mkdocs-glightbox#5)) * Supported glightbox built-in caption with title and description ([#4](blueswen/mkdocs-glightbox#4)) * Fixed page jitter when lightbox closing issue using Material for MkDocs * Add white background for lightbox images to prevent the displaying issue of the transparent image on black background </code></pre> <p>mkdocs-glightbox-0.2.1 (2022-08-10)</p> <pre><code>* Updated readme </code></pre> <p>mkdocs-glightbox-0.2.0 (2022-08-10)</p> <pre><code>* Added support for disabling glightbox with image class or page meta ([#2](blueswen/mkdocs-glightbox#2)) </code></pre> <p>mkdocs-glightbox-0.1.7 (2022-07-26)</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/1f086123bdda7214961e4df4494edd253b8ee9e2"><code>1f08612</code></a> Support custom background and shadow (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/27">#27</a>)</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/bbe99498a936ba6292854b0886a48a608aacf5d6"><code>bbe9949</code></a> Update docs</li> <li>See full diff in <a href="https://github.com/Blueswen/mkdocs-glightbox/compare/v0.3.6...v0.3.7">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
lars-reimann
pushed a commit
that referenced
this issue
Jun 1, 2024
Bumps [mkdocs-glightbox](https://github.com/Blueswen/mkdocs-glightbox) from 0.3.7 to 0.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Blueswen/mkdocs-glightbox/releases">mkdocs-glightbox's releases</a>.</em></p> <blockquote> <h2>mkdocs-glightbox-0.4.0</h2> <ul> <li>Supported manual mode (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/29">#29</a>)</li> <li>Allow calling lightbox methods from other places (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/34">#34</a>)</li> <li>Added id to appended script tag (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/38">#38</a>)</li> <li>Access theme attribute directly (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/40">#40</a>)</li> <li>Better JavaScript Error Handling (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/36">#36</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/blueswen/mkdocs-glightbox/blob/main/CHANGELOG">mkdocs-glightbox's changelog</a>.</em></p> <blockquote> <p>mkdocs-glightbox-0.4.0 (2023-05-06)</p> <pre><code>* Supported manual mode ([#29](blueswen/mkdocs-glightbox#29)) * Allow calling lightbox methods from other places ([#34](blueswen/mkdocs-glightbox#34)) * Added id to appended script tag ([#38](blueswen/mkdocs-glightbox#38)) * Access theme attribute directly ([#40](blueswen/mkdocs-glightbox#40)) * Better JavaScript Error Handling ([#36](blueswen/mkdocs-glightbox#36)) </code></pre> <p>mkdocs-glightbox-0.3.7 (2023-01-24)</p> <pre><code>* Supported custom background and shadow ([#27](blueswen/mkdocs-glightbox#27)) </code></pre> <p>mkdocs-glightbox-0.3.6 (2023-12-30)</p> <pre><code>* Modified width default to auto prevent zooming large image bug ([#21](blueswen/mkdocs-glightbox#21)) * Supported only enable glightbox with on-glb class in given page ([#28](blueswen/mkdocs-glightbox#28)) </code></pre> <p>mkdocs-glightbox-0.3.5 (2023-11-18)</p> <pre><code>* Supported compatibility with the privacy plugin of Material for MkDocs insiders ([#25](blueswen/mkdocs-glightbox#25)) </code></pre> <p>mkdocs-glightbox-0.3.4 (2023-04-25)</p> <pre><code>* Fixed regex bug: quote issue and empty alt issue ([#14](blueswen/mkdocs-glightbox#14) [#19](blueswen/mkdocs-glightbox#19)) </code></pre> <p>mkdocs-glightbox-0.3.3 (2023-04-20)</p> <pre><code>* Refactored processing logic with regex ([#14](blueswen/mkdocs-glightbox#14)) </code></pre> <p>mkdocs-glightbox-0.3.2 (2023-03-19)</p> <pre><code>* Supported image without extension ([#13](blueswen/mkdocs-glightbox#13)) </code></pre> <p>mkdocs-glightbox-0.3.1 (2022-11-22)</p> <pre><code>* Supported lightbox slide effect customization ([#8](blueswen/mkdocs-glightbox#8)) * Supported synchronized lightbox caption dark mode with Material for MkDocs ([#7](blueswen/mkdocs-glightbox#7)) * Supported glightbox built-in gallery feature ([#11](blueswen/mkdocs-glightbox#11)) * Supported skip image in the anchor tag </code></pre> <p>mkdocs-glightbox-0.3.0 (2022-09-29)</p> <pre><code>* Fixed width and height setting in config not working bug * Supported specific skip class ([#5](blueswen/mkdocs-glightbox#5)) * Supported glightbox built-in caption with title and description ([#4](blueswen/mkdocs-glightbox#4)) * Fixed page jitter when lightbox closing issue using Material for MkDocs * Add white background for lightbox images to prevent the displaying issue of the transparent image on black background </code></pre> <p>mkdocs-glightbox-0.2.1 (2022-08-10)</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/7f68f19556c8d91eb45bed2f5e3b93f9d0b4e591"><code>7f68f19</code></a> v0.4.0</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/1409b0de89bd0aa930bbee0c2aa801c8b3391137"><code>1409b0d</code></a> Add manual mode</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/e5ce7c9214f2de3647cbb1c9a1ec67bd82b387f9"><code>e5ce7c9</code></a> Add search plugin note</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/d7747e7e1e58e8fe5868f38292bbb6a65f5ac902"><code>d7747e7</code></a> Merge pull request <a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/29">#29</a> from michalfapso/main</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/6895d4eb60ef383530f8a807bec19404342a74c3"><code>6895d4e</code></a> Add test case</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/dc38a6c042da9dcf949a594940f312cfbf5cc1ae"><code>dc38a6c</code></a> try catch prevent Uncaught TypeError (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/36">#36</a>)</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/7d2c0ab4b214759f7ab22ab9e775c609718ad061"><code>7d2c0ab</code></a> access theme attribute directly (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/40">#40</a>)</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/b0b63f8fa2bfbd14812c95b466af180e34db2cc4"><code>b0b63f8</code></a> Merge pull request <a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/34">#34</a> from AndBondStyle/main</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/8e652652429851d18a0c920ca1ddcbf12ab71fdf"><code>8e65265</code></a> update validation condition</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/4963fdb93c4f483827bcab10c5289452068e1fb5"><code>4963fdb</code></a> Merge branch 'main' into main</li> <li>Additional commits viewable in <a href="https://github.com/Blueswen/mkdocs-glightbox/compare/v0.3.7...v0.4.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Template strings are currently fully rendered with a single color, even the template expression.
Describe the solution you'd like
Template expressions should stand out, which requires semantic highlighting.
The text was updated successfully, but these errors were encountered: