Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

more secure docker-compose example with clair support #1727

Closed
wants to merge 1 commit into from
Closed

more secure docker-compose example with clair support #1727

wants to merge 1 commit into from

Conversation

suntorytimed
Copy link
Contributor

Summary

Improvement of solution for #1714

  • uses SSL encryption for registry
  • uses SSL encryption for frontend
  • uses nginx for serving portus

@suntorytimed
Copy link
Contributor Author

@mssola is there anything that I have to take care of in terms of travis-ci? I didn't change any of the src files for building the project. Are the docker-compose examples checked as well?

Copy link
Collaborator

@mssola mssola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Somehow this PR slipped through...

I think that this error is due to the original docker-compose.clair.yml file being used for integration tests purposes. So, I'd recommend changing the bin/integration/integration.rb file and change the compose_file method as follows (you will have to rebase first):

def compose_file
  profile = case ENV["PORTUS_INTEGRATION_PROFILE"]
            when /^ldap/
              ".ldap"
            else
              ".clair-insecure"
            end
  "docker-compose#{profile}.yml"
end

@suntorytimed
Copy link
Contributor Author

Hi @mssola

thanks for reviewing the submit and for supplying me with a solution for the build errors. I have rebased my branch and added the necessary patch for /bin/integration/integration.rb

Improvement of solution for #1714
* uses SSL encryption for registry
* uses SSL encryption for frontend
* uses nginx for serving portus

Signed-off-by: Stefan Weiberg <[email protected]>
@suntorytimed suntorytimed reopened this Aug 3, 2018
@suntorytimed
Copy link
Contributor Author

instead of changing all the tests I decided to rename my compose file instead ;)

@suntorytimed
Copy link
Contributor Author

For some reason Travis CI complained about git status. I have opened a new pull request (#1925)including the changes discussed in here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants