Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Add a new docker-compose example for version 2.3 including clair and webpack #1714

Closed
suntorytimed opened this issue Mar 6, 2018 · 4 comments

Comments

@suntorytimed
Copy link
Contributor

suntorytimed commented Mar 6, 2018

Description

The current secure docker-compose example (master/examples/compose/) doesn't provide all new features of v2.3 (f. e. clair) and strongly differs from the development docker-compose.yml in master/

If clair and webpack are production ready those should be added to the example or an additional secure example should be created to support an easier setup of an up to date production environment.

@suntorytimed suntorytimed changed the title Add a new docker-compose example for version 2.3 with clair - master/examples/compose/secure Add a new docker-compose example for version 2.3 including clair and webpack - master/examples/compose/secure Mar 6, 2018
@suntorytimed suntorytimed changed the title Add a new docker-compose example for version 2.3 including clair and webpack - master/examples/compose/secure Add a new docker-compose example for version 2.3 including clair and webpack Mar 6, 2018
@mssola
Copy link
Collaborator

mssola commented Mar 7, 2018

If clair and webpack are production ready those should be added to the example or an additional secure example should be created to support an easier setup of an up to date production environment.

As part of a re-implementation of the integration testing I'm currently working on (see #1667), I'll also provide an example with Clair in it. That being said, webpack is not needed. That's because production images will already have all the assets compiled, so we don't need a process to compile them 😉

I'll keep this open as a documentation issue as a reminder to provide the example. Thanks for the feedback 👍 !

@mssola mssola added this to the Release 2.4 milestone Mar 7, 2018
@suntorytimed
Copy link
Contributor Author

Thanks for the clarification concerning webpack and the addition to milestone 2.4.

@mssola
Copy link
Collaborator

mssola commented Mar 13, 2018

@suntorytimed I've just tested it and the example provided by #1716 should just work. Thanks for the feedback! 👍

@mssola mssola closed this as completed Mar 13, 2018
@suntorytimed
Copy link
Contributor Author

@mssola Thanks for the example. As far as I can see this is based on the insecure setup. I will enhance it to a version with SSL encryption using nginx, test it and submit a pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants