This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
portusctl: show a warning if the local registry has not been installed #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monstermunchkin
suggested changes
Oct 19, 2016
| # system. If it is, it will simply return true. Otherwise, it will ask the user | ||
| # whether or not to install the package first and then proceed. If the user | ||
| # doesn't want that, or some zypper command failed, then it returns false. All | ||
| # the decissions to be made by the user can be coerced with the environment |
| Runner.safe_exec("zypper", ["-q", "-n", "--no-gpg-checks", "in", REGISTRY_RPM]) | ||
| end | ||
|
|
||
| # TODO |
There was a problem hiding this comment.
Is this still relevant?
There was a problem hiding this comment.
Added proper documentation
| end | ||
|
|
||
| context "PORTUSCTL_FORCE has been set" do | ||
| it "returns true of the package already exists" do |
|
@monstermunchkin fixed |
monstermunchkin
approved these changes
Oct 19, 2016
tboerger
approved these changes
Oct 21, 2016
If the admin is using the `--local-registry` then we can help the admin to play safer: 1. If the docker-distribution-registry RPM has not been installed, then the user can decide to install it then. 2. If the RPM exists, then we warn the user about the fact that the config will be overwritten and ask for permission to proceed. 3. All this can be forced by providing the "PORTUSCTL_FORCE" environment variable. Fixes SUSE#712 Signed-off-by: Miquel Sabaté Solà <[email protected]>
mssola
force-pushed
the
portusctl-registry
branch
from
7364fcb
to
8d64992
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the admin is using the
--local-registrythen we can help the adminto play safer:
the user can decide to install it then.
config will be overwritten and ask for permission to proceed.
variable.
Fixes #712
Signed-off-by: Miquel Sabaté Solà [email protected]