Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Show a warning when the registry package is not installed but --local-registry was used #712

Closed
mssola opened this issue Feb 5, 2016 · 4 comments
Closed

Show a warning when the registry package is not installed but --local-registry was used #712

mssola opened this issue Feb 5, 2016 · 4 comments
Labels
enhancement just packaging

Comments

@mssola
Copy link
Collaborator

mssola commented Feb 5, 2016

In portusctl the registry package is not required, since one may have a docker registry already set up on another host. That being said, if the user is setting the --local-registry flag, then we know for sure that the registry has to be there.

For this reason, we could add a warning if the registry RPM has not been installed (not an error because maybe the user has the registry on a container or whatever).
@mssola mssola mentioned this issue Feb 5, 2016
Closed
@flavio
Copy link
Member

flavio commented Feb 5, 2016

Agreed, we should show a warning and do not apply registry's configuration

@mssola
Copy link
Collaborator Author

mssola commented Feb 5, 2016

do not apply registry's configuration

Maybe we should ask that to the user. Maybe the user already has a config.yml.

@flavio
Copy link
Member

flavio commented Feb 5, 2016

Maybe we should portusctl and, before overwriting any configuration file, it should show a warning and ask what to do.

portusctl could be configured to just overwrite everything by using a special cli flag.

@mssola
Copy link
Collaborator Author

mssola commented Feb 5, 2016

Agreed

@mssola mssola mentioned this issue Feb 5, 2016
Closed
@mssola mssola added this to the Provisioning & General Usage milestone Feb 22, 2016
@mssola mssola modified the milestones: Before the 2.1 release, Provisioning & General Usage Aug 9, 2016
mssola added a commit to mssola/Portus that referenced this issue Oct 19, 2016
@mssola
portusctl: show a warning if the local registry has not been installed
734cc82 
If the admin is using the `--local-registry` then we can help the admin
to play safer:

1. If the docker-distribution-registry RPM has not been installed, then
   the user can decide to install it then.
2. If the RPM exists, then we warn the user about the fact that the
   config will be overwritten and ask for permission to proceed.
3. All this can be forced by providing the "PORTUSCTL_FORCE" environment
   variable.

Fixes SUSE#712

Signed-off-by: Miquel Sabaté Solà <[email protected]>
@mssola mssola mentioned this issue Oct 19, 2016
Merged
mssola added a commit to mssola/Portus that referenced this issue Nov 17, 2016
@mssola
portusctl: show a warning if the local registry has not been installed
8d64992 
If the admin is using the `--local-registry` then we can help the admin
to play safer:

1. If the docker-distribution-registry RPM has not been installed, then
   the user can decide to install it then.
2. If the RPM exists, then we warn the user about the fact that the
   config will be overwritten and ask for permission to proceed.
3. All this can be forced by providing the "PORTUSCTL_FORCE" environment
   variable.

Fixes SUSE#712

Signed-off-by: Miquel Sabaté Solà <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement just packaging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flavio @mssola