Don't include objc headers in exception.m
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix cross compile issues (and also, it's faster to call objc_retain directly instead of using a selector)
madsmtm
force-pushed
the
fix-cross-compile
branch
from
3d9ebc5
to
a94f0dc
Compare
|
Sorry, I can't verify because I don't remember which project I was trying to cross-compile. |
|
Oh, wait, the error was also happening when cross-compiling this crate on its own. I'll check if that works with this. |
|
Yes, that fixes the issue for me too. |
This was referenced Aug 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6 on my machine. Can you verify this @fenhl?
And also, it's faster to call
objc_retaindirectly instead of using a selector.