Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow media source swapping #8

Merged
merged 3 commits into from
Apr 11, 2024
Merged

feat: allow media source swapping #8

merged 3 commits into from
Apr 11, 2024

Conversation

jboix
Copy link
Contributor

@jboix jboix commented Apr 10, 2024

Description

Resolved #7 by adding a new toggle pane button containing an input field for changing the current media of the player. Only URNs are accepted.

Changes Made

Checklist

  • I have followed the project's style and contribution guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.

jboix added 2 commits April 10, 2024 14:16
Adds a parameter to `SassWorkspaceCompiler#compile` function to disable the compression
of the resulting css.
Resolved #7 by adding a new toggle pane button containing an input field for changing
the current media of the player. Only URNs are accepted.

Other chnages:
- Disabled tracking for the preview player.
@jboix jboix requested a review from amtins April 10, 2024 12:34
@jboix jboix self-assigned this Apr 10, 2024
Copy link

github-actions bot commented Apr 10, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 90.15% 797 / 884
🔵 Statements 90.15% 797 / 884
🔵 Functions 90.74% 49 / 54
🔵 Branches 87.95% 73 / 83
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/index.js 0% 0% 0% 0% 1-42
src/components/preview-box.js 100% 85.71% 100% 100%
src/workspace/sass-workspace-compiler.js 100% 83.33% 100% 100%
src/workspace/workspace.js 0% 0% 0% 0% 1-23
Generated in workflow #23

src/index.js Fixed Show fixed Hide fixed
Copy link

github-actions bot commented Apr 10, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-11 09:44 UTC

Added a div container to ensure that the parent of the element passed to video.js is not
the shadow root directly. This workaround resolves the issue until a permanent fix is
implemented in video-js, see: videojs/video.js#8679
@jboix jboix force-pushed the feat/swap-media branch from cd68344 to c80eea1 Compare April 10, 2024 13:43
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jboix jboix added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit 36d6f2d Apr 11, 2024
4 checks passed
@jboix jboix deleted the feat/swap-media branch April 11, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enable swapping the media source
2 participants