Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable swapping the media source #7

Closed
jboix opened this issue Apr 9, 2024 · 0 comments · Fixed by #8
Closed

Enable swapping the media source #7

jboix opened this issue Apr 9, 2024 · 0 comments · Fixed by #8
Assignees
@jboix
Labels
enhancement New feature or request

Comments

@jboix
Copy link
Contributor

jboix commented Apr 9, 2024 •
edited
Loading

Description

As a user, I would like to have the ability to change the source of the media within the theme editor for my video player. This will allow testing the user experience when working with subtitles or managing live layouts.

Acceptance Criteria

  • The live preview section of the theme editor must include a new component for changing the source of the media.
  • The theme editor should only accept media sources that are URNs from SRGSSR content.

Suggested by @amtins in #6 (comment)
@jboix jboix added the enhancement New feature or request label Apr 9, 2024
@jboix jboix added this to Pillarbox Apr 9, 2024
@github-project-automation github-project-automation bot moved this to ✏️ Draft in Pillarbox Apr 9, 2024
@jboix jboix self-assigned this Apr 9, 2024
@jboix jboix moved this from ✏️ Draft to 🚧 In Progress in Pillarbox Apr 9, 2024
jboix added a commit that referenced this issue Apr 10, 2024
@jboix
feat: allow media source swapping
4d8f5f5 
Resolved #7 by adding a new toggle pane button containing an input field for changing
the current media of the player. Only URNs are accepted.

Other chnages:
- Disabled tracking for the preview player.
@jboix jboix mentioned this issue Apr 10, 2024
Merged
4 tasks
@jboix jboix moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Apr 10, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 11, 2024
@jboix
feat: allow media source swapping
f667be6 
Resolved #7 by adding a new toggle pane button containing an input field for changing
the current media of the player. Only URNs are accepted.

Other chnages:
- Disabled tracking for the preview player.
@jboix jboix closed this as completed in #8 Apr 11, 2024
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jboix jboix

Labels
enhancement New feature or request
Projects
Pillarbox
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow media source swapping SRGSSR/pillarbox-web-theme-editor
1 participant
@jboix