Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Gradle build logic #474

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Refactor Gradle build logic #474

merged 2 commits into from
Mar 18, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Mar 14, 2024 •
edited
Loading

Pull request

Description

This PR continues the work done in #468 and #469.

Changes made

It introduces some new plugin to standardize our build logic:

  • PillarboxAndroidApplicationPlugin to configure an Android application module
  • PillarboxAndroidLibraryComposePlugin to configure Compose in an Android library module
  • PillarboxAndroidLibraryLintPlugin to configure Lint in an Android library module
  • PillarboxAndroidLibraryPlugin to configure an Android library module

The following plugin have been renamed:

  • PillarboxPublishingPlugin → PillarboxAndroidLibraryPublishingPlugin
  • PillarboxTestedModulePlugin → PillarboxAndroidLibraryTestedModulePlugin

The loading of credentials to access GitHub Packages now uses Gradle's Provider API, to try to make it compatible with Configuration Cache.

The logic in buildSrc has been moved in a dedicated build-logic module.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 added the enhancement New feature or request label Mar 14, 2024
@MGaetan89 MGaetan89 self-assigned this Mar 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

Code Coverage

Overall Project 53.59% 🟢

There is no coverage information present for the Files changed

@StaehliJ StaehliJ added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit cf1577a Mar 18, 2024
10 checks passed
@StaehliJ StaehliJ deleted the refactor_gradle_build_logic branch March 18, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

@MGaetan89 MGaetan89

Labels
enhancement New feature or request
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGaetan89 @StaehliJ