Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve publishing configuration #468

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Mar 12, 2024

Pull request

Description

This PR creates a custom Gradle plugin to handle the publishing logic of our library modules: pillarbox-analytics, pillarbox-core-business, pillarbox-player, and pillarbox-ui.
By doing this, we can have the publishing logic in one place, so it is easier to maintain in the future, if the Gradle API changes, the Maven URL changes, ...

Note

To test this, I've published each module to Maven local, by running ./gradlew :<module>:publishToMavenLocal, but I didn't try an actual publication. Since we're doing a new release soon, it will be a good opportunity to test this.

Changes made

  • Self-explanatory

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 self-assigned this Mar 12, 2024
@MGaetan89 MGaetan89 added the enhancement New feature or request label Mar 12, 2024
@MGaetan89 MGaetan89 marked this pull request as draft March 12, 2024 17:23
@MGaetan89
Copy link
Member Author

Putting this to draft, as I discovered a couple more things that could be handled by the plugin.

Copy link

github-actions bot commented Mar 12, 2024

Code Coverage

Overall Project 53.38% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 changed the title Improve mvn credentials loading Improve publishing configuration Mar 12, 2024
@MGaetan89 MGaetan89 marked this pull request as ready for review March 12, 2024 18:50
@MGaetan89 MGaetan89 force-pushed the improve_mvn_credentials_loading branch from 5830e65 to d491c18 Compare March 13, 2024 08:04
@MGaetan89 MGaetan89 added this to the 1.0.0 milestone Mar 13, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit aaed6fb Mar 13, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the improve_mvn_credentials_loading branch March 13, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants