195 forced subtitles support #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
defagos
reviewed
Aug 11, 2023
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/extension/Format.kt
Outdated
Show resolved
Hide resolved
defagos
reviewed
Aug 11, 2023
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/extension/Format.kt
Outdated
Show resolved
Hide resolved
defagos
reviewed
Aug 11, 2023
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/extension/TrackSelectionParameters.kt
Outdated
Show resolved
Hide resolved
defagos
reviewed
Aug 11, 2023
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/extension/TrackSelectionParameters.kt
Show resolved
Hide resolved
defagos
reviewed
Aug 11, 2023
| @@ -79,13 +77,17 @@ fun TrackSelectionParameters.disableAudioTrack(): TrackSelectionParameters { | |||
| /** | |||
| * Default text track | |||
| * | |||
| * Reset [TrackSelectionParameters] for text as Default. | |||
| * | |||
| * @param context | |||
| * @return | |||
defagos
reviewed
Aug 11, 2023
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/extension/TrackSelectionParameters.kt
Outdated
Show resolved
Hide resolved
defagos
reviewed
Aug 11, 2023
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/extension/TrackSelectionParameters.kt
Show resolved
Hide resolved
defagos
reviewed
Aug 11, 2023
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/extension/TrackSelectionParameters.kt
Outdated
Show resolved
Hide resolved
defagos
approved these changes
Aug 11, 2023
Co-authored-by: Samuel Défago <[email protected]>
…SSR/pillarbox-android into 195-forced-subtitles-support
…nsion/TrackSelectionParameters.kt Co-authored-by: Samuel Défago <[email protected]>
…SSR/pillarbox-android into 195-forced-subtitles-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Improve handling of forced subtitles. Forced subtitle are special subtitles that are displayed in the same language of the current audio track and are always displayed if no other subtitles are selected.
Changes made
Changing audio and text tracks state has been changed. Now they setup TrackSelectionParameters with parameters that fit the need of forced subtitles.
Related to : #199
Checklist
mainbranch.