Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced subtitles support #195

Closed
3 tasks
StaehliJ opened this issue Aug 3, 2023 · 0 comments · Fixed by #201
Closed
3 tasks

Forced subtitles support #195

StaehliJ opened this issue Aug 3, 2023 · 0 comments · Fixed by #201
Assignees
Milestone

Comments

@StaehliJ
Copy link
Contributor

StaehliJ commented Aug 3, 2023

As a user I want forced subtitles to be automatically enabled when appropriate. I never want to see them or be able to select them directly.

Acceptance criteria

  • Forced subtitles are automatically enabled based on the currently selected audio language.
  • Forced subtitles are never returned from usual public player APIs.
  • Forced subtitles cannot be selected via the public player API.
  • Forced subtitles are not displayed in the demo.

Documentation

Hints

TrackSelector can select the correct forced text track based on the preferred language or default audio track selected, but not if the user overrides the audio track. Should we handle this use cases?

Tasks

  • Filter forced subtitles from subtitle lists.
  • Ensure forced subtitles cannot be selected from the public API, even if they were retrieved in some other way (e.g. directly from the queue player asset).
  • Automatically enable forced subtitles based on the currently selected audio language, when no subtitle track has been explicitly selected.
@StaehliJ StaehliJ converted this from a draft issue Aug 3, 2023
@StaehliJ StaehliJ added this to the Tracks milestone Aug 3, 2023
@StaehliJ StaehliJ moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Aug 9, 2023
@StaehliJ StaehliJ linked a pull request Aug 10, 2023 that will close this issue
6 tasks
@StaehliJ StaehliJ moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Aug 10, 2023
@StaehliJ StaehliJ moved this from 🍿 Code Review to 🚧 In Progress in Pillarbox Aug 10, 2023
@StaehliJ StaehliJ moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Aug 10, 2023
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant