Fix memory leaks identified in testing. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessdtate
approved these changes
Jun 1, 2022
dcwhite
requested changes
Aug 11, 2023
| @@ -541,6 +541,13 @@ int vtkCleaverImageToUnstructuredGridFilter::RequestData(vtkInformation* vtkNotU | |||
| // mesh->writeInfo(output_path + output_name, verbose); | |||
| fillUnstructuredGrid(output, mesh); | |||
|
|
|||
| // clean up memory | |||
| for(auto* field: fields) | |||
There was a problem hiding this comment.
The field pointers in this vector are new'ed up manually in both segmentationToIndicatorFunctions and loadIndicatorFunctions--why can't these functions return vectors of unique_ptrs themselves? That's your code, not the cleaver API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleaver API prevents me from using
std::vector<std::unique_ptr<...>>to manageFloatFieldand itsdata()so I decided to delete them manually.