COMP: Clean up TetMesh halfEdges #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses memory leak and crash in itk-wasm/ITKCleaver WASI build:
```
ror: failed to run main module `./wasi-build/itk-cleaver.wasi.wasm`
Caused by:
0: failed to invoke command default
1: error while executing at wasm backtrace:
0: 0x2237dc - <unknown>!__cxx_global_array_dtor.1998
1: 0xb09e1 - <unknown>!__funcs_on_exit
2: 0xb095f - <unknown>!__wasm_call_dtors
3: 0x327f1f - itk_wasm_delayed_exit
at /ITKWebAssemblyInterface/src/initialization.cxx:36:3
4: 0x327fa8 - _start
at /ITKWebAssemblyInterface/src/initialization.cxx:63:3
2: wasm trap: undefined element: out of bounds table access
```
|
And some possibly relevant fixes in this work in progress branch: |
jessdtate
approved these changes
Apr 7, 2023
jcfr
added a commit
to jcfr/ITKCleaver
that referenced
this pull request
May 12, 2023
Since SCIInstitute/Cleaver#122 was integrated, this commit references the corresponding merge commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses memory leak and crash in itk-wasm/ITKCleaver WASI build: